Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Request.route publicly settable #2315

Merged
merged 1 commit into from Apr 14, 2020
Merged

Make Request.route publicly settable #2315

merged 1 commit into from Apr 14, 2020

Conversation

jdmcd
Copy link
Member

@jdmcd jdmcd commented Apr 14, 2020 •
edited by tanner0101

Makes Request.route publicly settable (#2315). This makes it easier to build and use custom Responder types.

@jdmcd jdmcd requested a review from tanner0101 April 14, 2020 19:54
@tanner0101 tanner0101 added the enhancement New feature or request label Apr 14, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Apr 14, 2020
@tanner0101 tanner0101 added the semver-minor Contains new API label Apr 14, 2020
@tanner0101 tanner0101 changed the title Make route public Make Request.route publicly settable Apr 14, 2020
@jdmcd jdmcd merged commit d00c85d into master Apr 14, 2020
Vapor 4 automation moved this from Awaiting Review to Done Apr 14, 2020
@jdmcd jdmcd deleted the configurable-responder-logging branch April 14, 2020 20:01
@tanner0101
Copy link
Member

These changes are now available in 4.1.0

@tdotclare
Copy link
Contributor

Woohoo!!

pull bot pushed a commit to scope-demo/vapor that referenced this pull request Apr 14, 2020
@jdmcd @pull
Make route public (vapor#2315)
ecf48f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new API
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdmcd @tanner0101 @tdotclare