Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numbers in header directive keys #2317

Merged
merged 1 commit into from Apr 16, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Apr 16, 2020

HTTP header directive keys now support numbers. This fixes an issue with cookies not being parsed correctly when the key included a number in the name (#2317, fixes #2316).

@tanner0101 tanner0101 added the bug Something isn't working label Apr 16, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Apr 16, 2020
@tanner0101 tanner0101 added the semver-patch Internal changes only label Apr 16, 2020
@tanner0101 tanner0101 changed the title add support for numbers in header directive keys Support numbers in header directive keys Apr 16, 2020
@tanner0101 tanner0101 merged commit 0aad60e into master Apr 16, 2020
Vapor 4 automation moved this from Awaiting Review to Done Apr 16, 2020
@tanner0101 tanner0101 deleted the tn-header-directive-number branch April 16, 2020 17:41
@tanner0101
Copy link
Member Author

These changes are now available in 4.2.1

pull bot pushed a commit to scope-demo/vapor that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Development

Successfully merging this pull request may close these issues.

Cookie not being parsed correctly
1 participant