Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $PORT and $HOSTNAME #2333

Closed
tanner0101 opened this issue Apr 24, 2020 · 3 comments
Closed

Support $PORT and $HOSTNAME #2333

tanner0101 opened this issue Apr 24, 2020 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@tanner0101
Copy link
Member

tanner0101 commented Apr 24, 2020

Support PORT and HOSTNAME environment variables for setting server configuration. These should override the default configured port / hostname when present in the environment. --port and --hostname passed via the CLI should still take precedent.

vapor/api-template#93 (comment)

@tanner0101 tanner0101 added the enhancement New feature or request label Apr 24, 2020
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Apr 24, 2020
@gwynne
Copy link
Member

gwynne commented Apr 30, 2020

@tanner0101 To fully replace the functionality currently found to be unavailable via CMD in Dockerfiles (for multiple reasons), you will also need an ENVIRONMENT, ENV, or (my personal favorite) VAPOR_ENV corresponding to --env.

@tanner0101
Copy link
Member Author

From Discord, these seem like the best options in terms of variable naming:

  • LOG_LEVEL
  • SERVER_HOSTNAME
  • SERVER_PORT
  • VAPOR_ENV

@mattpolzin
Copy link
Member

Not sure if it’s really worth much to support Heroku out of box but that would come for free with the ENV var named PORT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Development

No branches or pull requests

3 participants