Fix invalid session ID handling #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously Now, if a session identifier is not recognized, the invalid identifier is discarded and a new session with a new identifier is created. This means passing an invalid identifier has the same behavior as passing no identifier at all. I think this makes more sense than throwing an error since session identifiers can become invalid or expire normally. |
tdotclare
approved these changes
May 6, 2020
| } else { | ||
| // Session id not found, create new session. | ||
| request._sessionCache.session = .init() | ||
| } |
|
These changes are now available in 4.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests containing unrecognized session IDs will now result in a new session being created (#2347, fixes #2339).
This fixes a problem where clearing browser cookies would be required after changing Vapor's session driver.