Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove percent encoding when logging url path #2399

Merged
merged 2 commits into from Jun 24, 2020

Conversation

valeriomazzeo
Copy link
Contributor

@valeriomazzeo valeriomazzeo commented Jun 15, 2020

Remove percent encoding when logging url path (#2399)

The DefaultResponder now removes the percent encoding when logging the url request's path.

Previous log:

[ INFO ] GET /users/auth0%7C59abc/

After this change:

[ INFO ] GET /users/auth0|59abc/

## Current behaviour

`[ INFO ] GET /users/auth0%7C59abc/`

## Expected behaviour

`[ INFO ] GET /users/auth0|59abc/`
@Joannis
Copy link
Member

Joannis commented Jun 22, 2020

@valeriomazzeo can you replace the PR's message with a release note styled text? This'll be used by the release bot for those purposes.

If you need an example, check out this (closed & merged) PR by Tanner: #2400 Let me know if you need help, by mentioning me here or on Discord.

@Joannis Joannis added the semver-patch Internal changes only label Jun 22, 2020
Copy link
Sponsor Member

@MrLotU MrLotU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MrLotU MrLotU merged commit 6810c21 into vapor:master Jun 24, 2020
@tanner0101
Copy link
Member

These changes are now available in 4.10.2

@valeriomazzeo valeriomazzeo deleted the patch-1 branch June 24, 2020 09:16
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Jul 14, 2020
@tanner0101 tanner0101 added the enhancement New feature or request label Jul 14, 2020
@tanner0101 tanner0101 moved this from Awaiting Review to Done in Vapor 4 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-patch Internal changes only
Projects
Vapor 4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants