Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #file usage for 5.3 #2411

Merged
merged 1 commit into from Jun 25, 2020
Merged

Fix #file usage for 5.3 #2411

merged 1 commit into from Jun 25, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Jun 25, 2020

Fixes issue with previous #file warning fix in 4.10.1 that caused incorrect file paths to be passed (#2411).

Wrapping the default #file parameter in parentheses prevents it from forwarding to the call site. The parentheses must be added before passing to the methods accepting #filePath.

See new discussion of SE-0274 for more information.

@tanner0101 tanner0101 added bug Something isn't working semver-patch Internal changes only labels Jun 25, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Jun 25, 2020
@tanner0101 tanner0101 marked this pull request as ready for review June 25, 2020 20:24
@tanner0101 tanner0101 merged commit 38a3ca9 into master Jun 25, 2020
Vapor 4 automation moved this from Awaiting Review to Done Jun 25, 2020
@tanner0101 tanner0101 deleted the tn-fix-filepath-2 branch June 25, 2020 20:24
@tanner0101
Copy link
Member Author

These changes are now available in 4.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant