Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #2412

Merged
merged 3 commits into from Jun 26, 2020
Merged

Logging improvements #2412

merged 3 commits into from Jun 26, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Jun 26, 2020 •
edited

Improves readability of framework log messages and adds API for controlling error logging (#2412).

  • Downgraded several instances of .error level logging to .debug.

Note: The developer should have control over all .error level logs generated as the result of incoming HTTP requests.

  • Added logLevel property to DebuggableError.

Note: This allows DebuggableError's to control how they are reported to logs. Vapor's default "route not found" error uses this new API to log at .debug level.

  • Fixed an issue causing stack traces to be included when logLevel > .trace.

Note: Stack traces were only meant to be reported at the .trace level as they generate significant output.

  • Error source information is no longer duplicated in logs.

@tanner0101 tanner0101 added the enhancement New feature or request label Jun 26, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Jun 26, 2020
@tanner0101 tanner0101 added the semver-minor Contains new API label Jun 26, 2020
@tanner0101 tanner0101 marked this pull request as ready for review June 26, 2020 16:19
@tanner0101 tanner0101 merged commit 0875ed1 into master Jun 26, 2020
Vapor 4 automation moved this from Awaiting Review to Done Jun 26, 2020
@tanner0101 tanner0101 deleted the tn-logging-fixes branch June 26, 2020 16:59
@tanner0101
Copy link
Member Author

These changes are now available in 4.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new API
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tanner0101