Byte Range request beyond end of file

[keniwhat]

Describe the bug

A byte range request beyond end of file returns HTTP Status 400 (Bad Request).

To Reproduce

Steps to reproduce the behavior:

1. Create vapor server with FileMiddlware.
2. Send a byte-range request that goes past end-of-file.
3. You will get a 400 error.

Expected behavior

While Vapor behaviour is technically correct, other servers (apache, AWS - apache or nginx?) are more forgiving, returning the remaining bytes in the file. As a consequence of this historical leniency, HTTP client code exists (open source) that technically have this bug, but will work with other servers but not Vapor.

Can vapor be made more lenient in this respect?
That is, if a byte range request goes past end of file, just return bytes to end of file.

Environment

• Vapor Framework version: 4.67.4
• Vapor Toolbox version: N/A
• OS version: Any

Additional context

I have patched vapor to affect this fix and it my client code works now with vapor.

[0xTim]

@keniwhat I think this makes sense to make Vapor a little less strict. The only thing that would make me hesitant would be the RFC saying we MUST NOT accept invalid range requests. If you can link to the IETF RFC for range stuff in the PR where I'm sure it says we only SHOULD accept valid range requests that would be great

[keniwhat]

As per this document (https://httpwg.org/specs/rfc7233.html), Section 2.1, the HTTP server should treat a range request beyond end-of-file as being upto end-of-file. Screenshot attached:

[0xTim]

@keniwhat even more reason to make Vapor more flexible then. Very happy to accept a PR 👍

[linus-hologram]

@0xTim is this still a thing? If so I'd look into it :)

[linus-hologram]

@0xTim any update on this?

[keniwhat]

I made the changes to the code and test as requested but it has not been merged. Let me know what you need from me to get this onto the main vapor/vapor project.

[bplattenburg]

@linus-hologram @keniwhat It looks like this is tracked in #2997?