Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Swift Tracing #3033

Open
0xTim opened this issue Jun 28, 2023 · 1 comment
Open

Adopt Swift Tracing #3033

0xTim opened this issue Jun 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@0xTim
Copy link
Member

0xTim commented Jun 28, 2023

Swift Tracing is now 1.0 so we should adopt it, probably in middleware to make is easy to add.

We need to be careful as it relies on TLVs so if we cross ELF boundaries we could lose the context, but I think we're ok if we use an async middleware. Will need to test the whole stack
@0xTim 0xTim added the enhancement New feature or request label Jun 28, 2023
@slashmo
Copy link
Sponsor Contributor

slashmo commented Jun 28, 2023 •
edited

@0xTim Glad to see this being tracked now 👍 Feel free to ping me once you're starting the implementation, then I could update my HTTP client/server example to use Vapor as well as Hummingbird: https://github.com/slashmo/swift-otel/tree/main/Examples/Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xTim @slashmo