Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSS Proxy Setup Broken #147

Open
GEverding opened this issue Jan 27, 2024 · 2 comments
Open

WSS Proxy Setup Broken #147

GEverding opened this issue Jan 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@GEverding
Copy link

Describe the bug

uri = "\(scheme)://\(host)\(relativePath)\(port)"

This will generate a url like wss://apple.com/asdf:55433 which is not valid for a normal target. For most wss connections the uri should be wss://app.com:443/relativepath assuming the proxy config looks like localhost:55433

Fix: uri = "\(scheme)://\(host):\(port)\(relativePath)"

To Reproduce

Theres a test case that simulates the incorrect result.

Expected behavior

Environment

  • Vapor Framework version:
  • Vapor Toolbox version:
  • OS version:

Additional context

Add any other context about the problem here.

@GEverding GEverding added the bug Something isn't working label Jan 27, 2024
@0xTim
Copy link
Member

0xTim commented Feb 13, 2024

Yeah that does look like a bug! Would you like to submit a PR?

@CWftw
Copy link

CWftw commented Feb 21, 2024

@0xTim Created a PR for this and another bug we found when using a proxy #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants