Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors running Variety with mongosh + DocumentDB #168

Open
CodyDWJones opened this issue May 25, 2023 · 0 comments
Open

Errors running Variety with mongosh + DocumentDB #168

CodyDWJones opened this issue May 25, 2023 · 0 comments
Labels
bug

Comments

@CodyDWJones
Copy link

I had to make some changes for Variety to run with the new MongoDB shell.

  • __quiet is no longer defined. While I couldn't find a way to determine whether --quiet was passed on the command line, that option's description is "Silence output from the shell during the connection process" which suggests it should not be overloaded to control the script's logging too.
  • tojson() is no longer defined.
  • db.getSisterDB() no longer exists. getSiblingDB() should be used instead.
  • Running the script logs the warning:
DeprecationWarning: Collection.count() is deprecated. Use countDocuments or estimatedDocumentCount.
  • Assigning dbQuery.prototype.reduce fails. This function is only used once, so the code would be just as simple if the function body were inlined.
CodyDWJones added a commit to CodyDWJones/variety that referenced this issue May 25, 2023
@CodyDWJones
PR for variety#168 - make Variety work with mongosh
b1105ab 
For simplicity this removes the use of the "--quiet" CLI flag and logs always.
It would be possible to add a "quiet" config option, so long as the
circular dependency between the logger and the config reader were
broken.
CodyDWJones added a commit to CodyDWJones/variety that referenced this issue May 26, 2023
@CodyDWJones
PR for variety#168 - make Variety work with mongosh
f0f7800 
It seems a JS script can no longer check if mongosh was started with
the --quiet flag, so this commit changes Variety to be always
verbose.

A "quiet" config option could be added that would be distinct from
the CLI's own --quiet, though the circular dependency between log()
and readConfig.read() would need to be broken.
CodyDWJones added a commit to CodyDWJones/variety that referenced this issue May 26, 2023
@CodyDWJones
PR for variety#168 - make Variety work with mongosh
8e966f0 
It seems a JS script can no longer check if mongosh was started with
the --quiet flag, so this commit changes Variety to be always
verbose.

A "quiet" config option could be added that would be distinct from
the CLI's own --quiet, though the circular dependency between log()
and readConfig.read() would need to be broken.
CodyDWJones added a commit to CodyDWJones/variety that referenced this issue May 26, 2023
@CodyDWJones
PR for variety#168 - make Variety work with mongosh
a2fde92 
It seems a JS script can no longer check if mongosh was started with
the --quiet flag, so this commit changes Variety to be always
verbose.

A "quiet" config option could be added that would be distinct from
the CLI's own --quiet, though the circular dependency between log()
and readConfig.read() would need to be broken.
@JamesCropcho JamesCropcho mentioned this issue Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesCropcho @CodyDWJones