Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /etc/varnish from our packages #106

Open
dridi opened this issue Aug 22, 2018 · 3 comments
Open

Remove /etc/varnish from our packages #106

dridi opened this issue Aug 22, 2018 · 3 comments
Labels

Comments

@dridi
Copy link
Member

dridi commented Aug 22, 2018

From #105:

The fact that we maintain a default.vcl that is a copy of example.vcl is in my opinion something we should kill at some point in the weekly branch and keep maintaining for the 6.x series. Much like we simplified our packaging by no longer generating a secret and letting varnishd generate one, I'd like to replace the -f /etc/varnish/default.vcl option with -b localhost:8080 and let users decide how they operate their VCL.

The only reason why we ship things in /etc/varnish and especially a default.vcl is tradition. There's nothing in varnish-cache itself that warrants such a default configuration. I suggest we make this change to the weeklies after the Sep 2018 release.

@dridi dridi added the weekly label Aug 22, 2018
@dridi dridi mentioned this issue Aug 22, 2018
@gquintard
Copy link
Member

I'm a bit on the fence about this, I clearly follow the desire to clean things up, but:

  • -b won't get you very far
  • people will add -f and immediately get a conflict error because of -b
  • default.vcl was here, ready to be modified, I assume example.vcl will (have to) be copied over?

@lkarsten
Copy link

I don't think this is a good idea.

Significant part of the value you get from Varnish is VCL.

I can't think of a single dynamic site that won't end up in return(pass) because of cookies everywhere, if someone tried to use -b today. This will create another step anyone new to Varnish must accomplish to get it going/caching, and that is just wasted effort instead of doing it at the packaging level.

@dridi
Copy link
Member Author

dridi commented Jan 31, 2019

This came up again during a discussion and I still think we should ship an empty /etc/varnish directory. If the only argument I get is the need for an extra configuration step (because so far it comes down to that) then I'm willing to ignore it.

We already ship a default ExecStart that requires a manual change either by dropping a new varnish.service somewhere in /etc or by using a systemd override. Unless of course if -s malloc 256m is something we recommend users to stick to.

At the very least, moving from -f to -b doesn't change the fact that today 1) you have a working service out of the box and 2) you need to do some sysadmin work to get it in a production-ready state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants