-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
varnishadm
always returns 0 (success) when commands sent via STDIN
#4012
Comments
This is not optimal. The problem is you dont want varnishadm to give up in interactive mode. Bugwash consensus: Give varnishadm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
varnishadm
returns a non-zero exit code when any command sent via STDIN fails.Current Behavior
Regardless of how many commands are sent to
varnishadm
and whether any of them fail or not, it always returns a zero (success) code.Possible Solution
Whenever any command fails in a series of commands sent to
varnishadm
, the program stops at that point. The exit code of that command should be used when the main process exits.Steps to Reproduce (for bugs)
Context
See varnishcache/pkg-varnish-cache#170.
Varnish Cache version
varnishd (varnish-6.6.1 revision e6a8c86)
Operating system
Ubuntu 22.04.3 LTS
Source of binary packages used (if any)
http://nova.clouds.archive.ubuntu.com/ubuntu
The text was updated successfully, but these errors were encountered: