Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests from Enzyme to React Testing Library #1130

Open
radekmie opened this issue Jun 10, 2022 · 3 comments · Fixed by #1193, #1312, #1304, #1303 or #1302
Open

Migrate tests from Enzyme to React Testing Library #1130

radekmie opened this issue Jun 10, 2022 · 3 comments · Fixed by #1193, #1312, #1304, #1303 or #1302
Assignees
@ErnestTeluk
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages
Projects
Open Source (migrated)
Milestone
v4.0

Comments

@radekmie
Copy link
Contributor

radekmie commented Jun 10, 2022 •
edited

As Enzyme is no longer supported and we already rely on a community-made workaround for React v17 and there's nothing sure for v18 we should push for getting rid of it entirely.

Support for v18 was requested in #1109 and added in #1129.
@radekmie radekmie added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages labels Jun 10, 2022
@radekmie radekmie added this to the v3.x milestone Jun 10, 2022
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Jun 10, 2022
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Jun 10, 2022
@radekmie
Copy link
Contributor Author

radekmie commented Jul 1, 2022

Maybe we could try enzymejs/enzyme#2524 (comment) to buy us more time?

@ErnestTeluk ErnestTeluk moved this from To do to In progress in Open Source (migrated) Jul 1, 2022
@ErnestTeluk
Copy link
Contributor

ErnestTeluk commented Jul 1, 2022 •
edited

Maybe we could try enzymejs/enzyme#2524 (comment) to buy us more time?

Unfortunately it did not work (tested on react 17), when it comes to react 18 there is one more blocker which is facebook/docusaurus#7264 . So we have to wait for docusaurus 3.0 to come out anyway

@radekmie radekmie modified the milestones: v3.x, v4.0 Oct 7, 2022
@ErnestTeluk ErnestTeluk linked a pull request Dec 2, 2022 that will close this issue
Migrate core tests from Enzyme to React Testing Library #1193
Merged
8 tasks
@ErnestTeluk ErnestTeluk removed a link to a pull request Dec 2, 2022
Migrate core tests from Enzyme to React Testing Library #1193
Merged
8 tasks
@ErnestTeluk ErnestTeluk linked a pull request Dec 2, 2022 that will close this issue
Migrate core tests from Enzyme to React Testing Library #1193
Merged
8 tasks
@radekmie radekmie modified the milestones: v4.0, v4.x Jan 20, 2023
@kestarumper
Copy link
Member

kestarumper commented Feb 9, 2024 •
edited by zaxoavoki

This is a "current" state of knowledge of what we finished and what still needs to be done.

Done

Review

In Progress

TODO

  • Remove enzyme from dependencies
  • Remove legacy enzyme tests in favor of test suites

@kestarumper kestarumper reopened this Feb 9, 2024
@kestarumper kestarumper modified the milestones: v4.x, v4.0 Feb 9, 2024
@kestarumper kestarumper mentioned this issue Feb 9, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
Merged
Merged
@kestarumper kestarumper mentioned this issue Feb 16, 2024
Open
@zaxoavoki zaxoavoki mentioned this issue Feb 29, 2024
Merged
@kestarumper kestarumper linked a pull request Apr 7, 2024 that will close this issue
Migrated SelectField AntD tests to @testing-library/react #1312
Merged
This was linked to pull requests Apr 7, 2024
Migrated ListItemField tests to @testing-library/react #1304
Merged
Migrated BaseForm tests to @testing-library/react #1303
Merged
Migrated QuickForm tests to @testing-library/react #1302
Merged
Migrated connectField tests to @testing-library/react #1301
Merged
Migrated ListField tests to @testing-library/react #1299
Merged
Migrated TextField tests to @testing-library/react #1298
Merged
Migrated SelectField tests to @testing-library/react #1294
Merged
Migrated AutoFields tests to @testing-library/react #1271
Merged
@kestarumper kestarumper mentioned this issue Apr 12, 2024
Open
@zaxoavoki zaxoavoki mentioned this issue Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErnestTeluk ErnestTeluk

Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages
Projects
Open Source
Status: In progress
Open Source (migrated)
In progress
Milestone
v4.0
3 participants
@radekmie @kestarumper @ErnestTeluk