Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read receipts are moving upwards #20922

Closed
turt2live opened this issue Feb 4, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2160
Closed

Read receipts are moving upwards #20922

turt2live opened this issue Feb 4, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2160
Assignees
@t3chguy
Labels
A-Reactions A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@turt2live
Copy link
Member

on nightly. Appears to be caused by messages being received at different speeds so RRs end up on the 'wrong' event
@SimonBrandner SimonBrandner added A-Reactions A-Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 4, 2022
@germain-gg
Copy link
Contributor

Could you add a bit more information regarding your setup and maybe a screen recording so that we can validate this behaviour still occurs when we get to this issue?

I'm a bit unsure how to determine whether an RR ends up on a wrong event or not

@germain-gg germain-gg added the X-Needs-Info This issue is blocked awaiting information from the reporter label Feb 7, 2022
@t3chguy t3chguy self-assigned this Feb 7, 2022
@t3chguy t3chguy mentioned this issue Feb 7, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 15, 2022
@su-ex
Merge tag 'v15.5.1' into sc
252d90f 
* Fix issue with rooms not getting marked as unread ([\matrix-org#2163](matrix-org#2163)). Fixes element-hq/element-web#20971.
* Don't store streams that are only used once ([\matrix-org#2157](matrix-org#2157)). Fixes element-hq/element-web#20932. Contributed by @SimonBrandner.
* Fix edge cases around RR calculations ([\matrix-org#2160](matrix-org#2160)). Fixes element-hq/element-web#20922.
* Account for encryption in `maySendMessage()` ([\matrix-org#2159](matrix-org#2159)). Contributed by @SimonBrandner.
* Send references to thread root to threads, even out of order ([\matrix-org#2156](matrix-org#2156)).
* Fix initial sync fail when event fetching unsuccessful ([\matrix-org#2150](matrix-org#2150)). Fixes element-hq/element-web#20862.
* Don't decrypt redacted messages ([\matrix-org#2143](matrix-org#2143)). Contributed by @SimonBrandner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Reactions A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix edge cases around RR calculations matrix-org/matrix-js-sdk
4 participants
@germain-gg @turt2live @t3chguy @SimonBrandner