Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck unread indicators #20971

Closed
robintown opened this issue Feb 7, 2022 · 11 comments · Fixed by matrix-org/matrix-js-sdk#2163
Closed

Stuck unread indicators #20971

robintown opened this issue Feb 7, 2022 · 11 comments · Fixed by matrix-org/matrix-js-sdk#2163
Assignees
@t3chguy
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@robintown
Copy link
Member

Steps to reproduce

This behavior started at a seemingly random time, but is now happening to me consistently:

  1. Receive a message
  2. View the message to mark it as read

Outcome

What did you expect?

The room should not have any notification indicators on it since I have read all the messages.

What happened instead?

The room still has an unread dot that won't go away:

Screenshot 2022-02-07 at 14-39-14 Element sandbox

Reloading Element causes it to disappear.

Operating system

NixOS unstable

Browser information

Firefox 96.0.2

URL for webapp

develop.element.io

Application version

Element version: 64242a0-react-8e72118b5d4a-js-07171a95c4f0 Olm version: 3.2.8

Homeserver

Synapse 1.51.0

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Notifications labels Feb 7, 2022
@robintown robintown changed the title Unread dots don't go away Stuck unread indicators Feb 7, 2022
@tcitworld
Copy link

tcitworld commented Feb 8, 2022 •
edited

I have the same issue, also on 64242a0-react-8e72118b5d4a-js-07171a95c4f0

@andybalaam
Copy link
Contributor

I just hit this problem and rageshaked.

@babolivier
Copy link
Contributor

Same, I've been observing this since yesterday evening. Only sending an event or refreshing the tab marks the room as unread.

@jryans jryans added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 8, 2022
@RiotRobot RiotRobot added this to P1 in Web App Team Feb 8, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 8, 2022

Possible regression caused by matrix-org/matrix-js-sdk@07171a95c4f0

@dbkr
Copy link
Member

dbkr commented Feb 8, 2022

Other reports of this coming in (including me) so marking as blocker

@t3chguy t3chguy moved this from P1 to In Review in Web App Team Feb 8, 2022
@t3chguy t3chguy self-assigned this Feb 8, 2022
@t3chguy t3chguy mentioned this issue Feb 8, 2022
Merged
Web App Team automation moved this from In Review to In Test Feb 8, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 15, 2022
@su-ex
Merge tag 'v15.5.1' into sc
252d90f 
* Fix issue with rooms not getting marked as unread ([\matrix-org#2163](matrix-org#2163)). Fixes element-hq/element-web#20971.
* Don't store streams that are only used once ([\matrix-org#2157](matrix-org#2157)). Fixes element-hq/element-web#20932. Contributed by @SimonBrandner.
* Fix edge cases around RR calculations ([\matrix-org#2160](matrix-org#2160)). Fixes element-hq/element-web#20922.
* Account for encryption in `maySendMessage()` ([\matrix-org#2159](matrix-org#2159)). Contributed by @SimonBrandner.
* Send references to thread root to threads, even out of order ([\matrix-org#2156](matrix-org#2156)).
* Fix initial sync fail when event fetching unsuccessful ([\matrix-org#2150](matrix-org#2150)). Fixes element-hq/element-web#20862.
* Don't decrypt redacted messages ([\matrix-org#2143](matrix-org#2143)). Contributed by @SimonBrandner.
@dkasak
Copy link
Member

dkasak commented Feb 16, 2022

I recently started having the opposite issue, where the unread messages indicator is never shown despite there being new room messages. Any chance that's related to this bug or should I submit a new issue?

@robintown
Copy link
Member Author

@dkasak That sounds like #20859 which was fixed recently. What version are you using?

@dkasak
Copy link
Member

dkasak commented Feb 16, 2022

Could be, I'm still on v1.10.1. Though the fix for that issue talks about mentions explicitly, and my issue is not related to mentions specifically.

@schichtnudelauflauf
Copy link

That still happens in Element, Schildichat and Fluffychat.
It was never gone.

@edsu
Copy link

edsu commented Feb 13, 2024

This is still broken in v1.11.57.

@Weuxel
Copy link

Weuxel commented Mar 1, 2024

Still in 1.11.58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with rooms not getting marked as unread matrix-org/matrix-js-sdk