Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish-auto is failing #1389

Closed
SeanKeenan-at opened this issue Sep 2, 2022 · 7 comments
Closed

Publish-auto is failing #1389

SeanKeenan-at opened this issue Sep 2, 2022 · 7 comments

Comments

@SeanKeenan-at
Copy link

SeanKeenan-at commented Sep 2, 2022

It appears as if the underlying issue is with auto.

See here for the first publish-auto that is failing. (Which seems unrelated to the auto issue).

The issue does reproduce locally (for me) if you run yarn release.

The impact of this is that next is not being kept up to date

@domoritz
Copy link
Member

domoritz commented Sep 2, 2022

Yeah, I've seen it. It seems to be an issue with ts-node and the latest ts version (@hydrosquall found that: microsoft/TypeScript#49257 (comment)).

I filed intuit/auto#2242 but no response so far.

I don't want to roll back ts if I can avoid it so I've been just waiting.

@mohd-akram
Copy link
Contributor

Might be able to use Yarn's selective dependency resolutions to override this.

@domoritz
Copy link
Member

Updating ts-node did not help unfortunately.

@mohd-akram
Copy link
Contributor

Per the log, it seems this is due to an internal dependency of auto having an outdated ts-node.

@domoritz
Copy link
Member

https://github.com/vega/ts-json-schema-generator/blob/next/yarn.lock#L73 looks like it's new enough. Where are you seeing an old version?

@hydrosquall
Copy link
Member

hydrosquall commented Sep 21, 2022

I think @mohd-akram may be flagging the error cosmiconfig-typescript-loader, which is a dependency of auto

ts-node "^9"

In general, yarn why can be used to find out how many versions of a dependency are present, and how they came to be included.

image

The resolutions approach he proposed may work, but there's another option: this dependency is only being activated when it we write our config file in TS

https://github.com/vega/ts-json-schema-generator/blob/next/auto.config.ts

I think if we convert the config file to a JSON file (like https://github.com/vega/vega-lite/blob/next/.autorc.json ), and/or use selective resolution to resolve ts-node to 10^ across the board, we should be able to bypass any troubles created by the old version.

Opened a PR to convert the config file to see if that's enough: #1413

@domoritz
Copy link
Member

Looks like it's mostly fixed now. Thank you @hydrosquall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants