fix: support valid circular reference breaking the parsing process #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipomar
force-pushed
the
circular-reference-support
branch
from
0baf155
to
c341040
Compare
style: fixed typos
filipomar
force-pushed
the
circular-reference-support
branch
from
c341040
to
6119cbe
Compare
domoritz
changed the title
This was referenced Sep 21, 2022
Merged
|
🚀 PR was released in |
github-actions
bot
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238
I am not a big fan of this solution as it feels more hacky then anything else, but it does address the problem without introducing more bugs and still breaking (as they have before) on the edge cases I have not mapped out yet.
I'd love suggestions on an alternative solution if this one is not suitable.