fix: consistently use NeverType #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of undefined.
|
Very nice. Thank you! |
This was referenced Sep 21, 2022
Merged
|
🚀 PR was released in |
github-actions
bot
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
undefinedkeyword is used to represent thenevertype in provided TypeScript code. This is undesirable, as it can lead to some situations where the intended use of the keyword is ambiguous. Fortunately, #1154 added aNeverType, although it is only used marginally in the current version. As I previously mentioned in #1261, gradually switching toNeverTypeis hard, as it leads to regressions. Therefore, this pr aims to replace all affected occurrences of theundefinedkeyword withNeverType. Additionally, optional object properties with typeneverare now hidden by theObjectTypeFormatterwhenadditionalPropertiesisfalse.