Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hidden should not cause additionalProperties to be true. #1417

Merged
merged 2 commits into from Sep 22, 2022

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Sep 21, 2022

fix: #1416

  • Add HiddenType
  • Add HiddenTypeFormatter
  • Add test

@Jason3S Jason3S changed the title fix: Never should not have additionalProperties. fix: Hidden should not cause additionalProperties to be true. Sep 21, 2022
@domoritz domoritz merged commit 1a935d8 into vega:next Sep 22, 2022
@github-actions github-actions bot mentioned this pull request Sep 22, 2022
@github-actions
Copy link

🚀 PR was released in v1.1.1 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Sep 22, 2022
@Jason3S Jason3S deleted the fix-hidden-types branch September 22, 2022 04:43
sean9keenan added a commit to sean9keenan/ts-json-schema-generator that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading from 1.0.0 to 1.1.0 causes "additionalProperties": false to be dropped.
2 participants