Bug (?): Incorrect Compilation of Signal Names in Bin Parameters Resulting in Non-Unique Dataset Names

[dwootton]

Bug Description

When setting a bin parameter to a signal value, the transformed dataset compiles the signal name to object_Object instead of using the signal name. As such, any derived datasets from signals would be named the same thing, even if they used different signals to set the bin parameter. I've tried with resolving axis and scales in concatenated charts; however, neither solves the issue.

Example

Minimal working example

In this example, I'd expect the first slider to drive the max_bins in the first chart, and the second slider to control the max_bins of the second chart. However, the second slider controls both max_bins parameters.

The generated data_0 has a bin start field of bin_maxbins__object_Object__Miles_per_Gallon. I'd expect this to resolve to
bin_maxbins_slider1_Miles_per_Gallon and a second dataset that resolves to bin_maxbins_slider2_Miles_per_Gallon.

Solution

My guess is that this behavior come from the fact that bin params schema has not been updated to accept expressions, and as such, my work around of using a signal reference does not resolve to unique names.

Happy to submit a PR to update binParams to accept expressions if this is desired behavior.

As I'm already breaking the schema using this workaround, I'm not sure if this issue is technically a bug.

Checklist

• I checked for duplicate issues.