Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line with invalid null broken #9326

Open
kanitw opened this issue Apr 28, 2024 · 0 comments
Open

Line with invalid null broken #9326

kanitw opened this issue Apr 28, 2024 · 0 comments
Labels

Comments

@kanitw
Copy link
Member

kanitw commented Apr 28, 2024

Bug Description

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {
    "values": [
      {
        "x": -1,
        "y": null
      },
      {
        "x": 1,
        "y": 10
      },
      {
        "x": 2,
        "y": 30
      },
      {
        "x": 3,
        "y": null
      },
      {
        "x": 4,
        "y": 15
      },
      {
        "x": 5,
        "y": 30
      },
      { 
        "x": 6,
        "y": 40
      },
      {
        "x": 7,
        "y": 20
      },
      {
        "x": 10,
        "y": null
      }
    ]
  },
  "mark": {"type": "line", "invalid": null},
  "encoding": {
    "x": {"field": "x", "type": "quantitative"},
    "y": {"field": "y", "type": "quantitative"}
  }
}
image

All null values are interpreted as max values!!

kanitw added a commit that referenced this issue May 2, 2024
Previously we forgot to add conditional logic for invalid values when filtering is disabled (mark.invalid = null)
kanitw added a commit that referenced this issue May 2, 2024
## PR Description

Previously we forgot to add conditional logic for invalid values when
filtering is disabled (mark.invalid = null)

Interestingly, given area applies stack layout by default, it doesn't
suffer from the same bug that line does.

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant