Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): Bar Chart with Full-Height Hover Targets for Tooltip #8225

Merged
merged 4 commits into from Jun 22, 2022

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jun 13, 2022

image

📦 Published PR as canary version: 5.2.1--canary.8225.9a33014.0

✨ Test out this PR locally via:

npm install vega-lite@5.2.1--canary.8225.9a33014.0
# or 
yarn add vega-lite@5.2.1--canary.8225.9a33014.0

@kanitw kanitw requested a review from domoritz June 13, 2022 21:57
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the example but the implementation doesn't make me happy.

examples/specs/interactive_bar_full_height_hover.vl.json Outdated Show resolved Hide resolved
@kanitw
Copy link
Member Author

kanitw commented Jun 22, 2022

Merging since Dom is approving in the text.

@kanitw kanitw merged commit 8cbaed5 into next Jun 22, 2022
@kanitw kanitw deleted the kw/bar-full-height-hover branch June 22, 2022 05:14
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.3.1-next.0 🚀

BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
…ega#8225)

* docs(examples): Bar Chart with Full-Height Hover Targets for Tooltip

* fix names

* chore: update TOC [CI]

* chore: update examples [CI]

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants