Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fire direct manipulation point selections on legend entries #8268

Merged
merged 2 commits into from Jul 18, 2022

Conversation

arvind
Copy link
Member

@arvind arvind commented Jul 8, 2022

Fixes #8267.

/cc @kanitw

πŸ“¦ Published PR as canary version: 5.3.1--canary.8268.cd9f9c1.0

✨ Test out this PR locally via:

npm install vega-lite@5.3.1--canary.8268.cd9f9c1.0
# or 
yarn add vega-lite@5.3.1--canary.8268.cd9f9c1.0

Version

Published prerelease version: v5.3.1-next.0

Changelog

πŸ› Bug Fix

Authors: 3

@arvind arvind requested a review from a team July 8, 2022 14:55
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @arvind for super fast response to fix this issue. (Sorry for a slightly delayed reply, last week I was a bit swamped.)

@kanitw kanitw merged commit 3b8d676 into next Jul 18, 2022
@kanitw kanitw deleted the as/fix8267 branch July 18, 2022 16:29
@vega-org-bot
Copy link
Collaborator

πŸš€ PR was released in v5.3.1-next.0 πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend binding doesn't always update right away.
3 participants