Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Github action #156

Open
zekenie opened this issue Mar 3, 2024 · 5 comments
Open

Idea: Github action #156

zekenie opened this issue Mar 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@zekenie
Copy link

zekenie commented Mar 3, 2024

Idea: we use vl-convert in a github action at our company to make various up-to-date svg charts about our codebase health. We're stuck on a pretty old pinned version because of some rust compilation issue I don't want to investigate. I just realized it'd be pretty great if there was a public github action that i could just use instead of setting it up myself. Just wanted to share the idea! I'm sure i'm not the only one who'd use it

@jonmmease
Copy link
Collaborator

Thanks for the suggestion @zekenie.

Are you currently installing the CLI version of vl-convert with cargo? This will result in compilation from source. We do publish the CLI builds in GitHub Releases, so I suppose a GitHub action could automate the download of the correct release version.

@jonmmease jonmmease added the enhancement New feature or request label Mar 3, 2024
@zekenie
Copy link
Author

zekenie commented Mar 4, 2024

That's correct, i've been installing it with cargo. do you think the linux binary you have on the releases will "just work" in gh action land? it'd be great to be able to say

uses: "vega/vl-convert-action"
with:
  svg: ...
  spec: ...

@jonmmease
Copy link
Collaborator

do you think the linux binary you have on the releases will "just work" in gh action land?

Yeah, the pre-compiled linux-64, win-64, and osx-64 binaries should all work in GH actions. I haven't written a custom action before, but if you're interested in playing with it I'd be happy to review!

@domoritz
Copy link
Member

domoritz commented Mar 4, 2024

I'd say it's probably cleaner to just download the binary and unpack it instead of having an action. Something like https://github.com/uwdata/mosaic-framework-example/blob/0d960d308245f1dc5d532e177b629f62c1eb8c5f/.github/workflows/deploy.yml#L27 for duckdb. It's easier to debug when something goes wrong or adapt to a different platform.

@zekenie
Copy link
Author

zekenie commented Mar 4, 2024

@domoritz thanks, that example helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants