-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --inpackage-suffix option #453
Add --inpackage-suffix option #453
Conversation
This allows users to choose whether they prefer mock_name.go or name_mock.go for their filenames.
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 70.76% 70.89% +0.12%
==========================================
Files 7 7
Lines 1293 1302 +9
==========================================
+ Hits 915 923 +8
- Misses 325 326 +1
Partials 53 53
Continue to review full report at Codecov.
|
Thanks for the PR, and the great contributions in general. For this particular one, I'm not super excited to field obscure requests that don't really affect the usability or functionality of the project, as that leads to bloat. If it became a highly requested feature it'd be a different story, but I'm leaning towards a pass for now. |
Yeah, I can understand that. I'm personally not using the |
Will this fix be merged?? |
Can someone please merge it? or is there a blocking issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 10 months late, I'm deciding to approve this. Seems like enough people want this feature :) Will merge when tests pass.
This allows users to choose whether they prefer mock_name.go or name_mock.go for their filenames.
Description
I've seen this issue and it seemed like an easy pick, so here we are :D
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Run tests, tried
make mocks
, and it looks ok :)