Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InterfaceDirRelative template variable #625

Merged
merged 1 commit into from May 14, 2023
Merged

Add InterfaceDirRelative template variable #625

merged 1 commit into from May 14, 2023

Conversation

LandonTClipp
Copy link
Contributor

@LandonTClipp LandonTClipp commented May 14, 2023

This fixes #623

Also fixed in here was a bug where the template object was being reused. This caused subtle issues where if a templated variable was set to the empty string, the template would simply reuse the last parsed template.

This fixes #623

Also fixed in here was a bug where the template object was being reused. This caused subtle issues where if a templated variable was set to the empty string, the template would simply reuse the last parsed template.

Add docs/fix minor logic flow

Fix bug with test
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 85.00000% and project coverage change: +0.04841 🎉

Comparison is base (05d270e) 76.20159% compared to head (ca78159) 76.25000%.

❗ Current head ca78159 differs from pull request most recent head 66f7b66. Consider uploading reports for the commit 66f7b66 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #625         +/-   ##
===================================================
+ Coverage   76.20159%   76.25000%   +0.04841%     
===================================================
  Files              7           7                 
  Lines           2143        2160         +17     
===================================================
+ Hits            1633        1647         +14     
- Misses           374         376          +2     
- Partials         136         137          +1     
Impacted Files Coverage Δ
pkg/outputter.go 62.50000% <85.00000%> (+1.63042%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp LandonTClipp merged commit f9586f1 into vektra:master May 14, 2023
5 checks passed
@LandonTClipp LandonTClipp deleted the issue_623 branch May 14, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add {{.InterfaceDirRelative}} template variable
1 participant