Don't recurse into submodules on recursive: true
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #740 +/- ##
===================================================
+ Coverage 75.16639% 75.17584% +0.00944%
===================================================
Files 10 10
Lines 2404 2417 +13
===================================================
+ Hits 1807 1817 +10
- Misses 459 461 +2
- Partials 138 139 +1 ☔ View full report in Codecov by Sentry. |
LandonTClipp
force-pushed
the
monorepo
branch
from
c71ca27
to
bbdd716
Compare
This PR changes mockery to not recurse into paths that contain a `go.mod` submodule. This is to help support monorepos that contain many modules. In this case, mockery should not be recursing into these because it causes issues, like in issue vektra#706. fix deprecations in mkdocs remove explicit lint step
LandonTClipp
force-pushed
the
monorepo
branch
from
25fd514
to
b248492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes mockery to not recurse into paths that contain a
go.modsubmodule. This is to help support monorepos that contain many modules. In this case, mockery should not be recursing into these because it causes issues, like in issue #706.Type of change
Version of Golang used when building/testing: