Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #47

Open
rkristelijn opened this issue Oct 30, 2021 · 2 comments
Open

Accessibility #47

rkristelijn opened this issue Oct 30, 2021 · 2 comments

Comments

@rkristelijn
Copy link

Nowadays web sites and web apps need to adhere to accessibility standards, such as WCAG. When I run axe devtools on the storefront demo (https://demo.vendure.io/storefront/) I get a lot of issues.

image

Since the storefront is Angular, the most of it may be easily fixed by adding linting rules for accessibility. Also adding cypress and cypress-axe can help.

sources: https://angular.io/guide/accessibility

@michaelbromley
Copy link
Member

Hi, thanks for bringing this to my attention. Although this demo is not intended to be used in real production scenarios, I agree that it makes sense to at least handle those issues that can be easily solved, so that if someone chooses to build their project based on this, then they will have a better more accessible starting point.

@michaelbromley
Copy link
Member

Assigning to @zmilan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants