Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycling through quantity of an item in the cart doesnt update properly #89

Open
DanielBiegler opened this issue Apr 12, 2023 · 6 comments

Comments

@DanielBiegler
Copy link

Doesnt seem to get cached properly? If you cycle through with arrow-keys the whole thing updates wrong and jumps around.

  1. Add an item to your cart
  2. Focus the quantity input
  3. Press arrow-down key a couple of times in a row
  4. Now the count should bug out

If you want to see it in its glory just hold down arrow-down for a higher repeat-speed, then its completely broken.

Screencast.from.12.04.2023.09.51.23.webm
@gioboa
Copy link
Collaborator

gioboa commented Apr 12, 2023

Thanks @DanielBiegler for the report. Would you like to investigate into the problem?

@DanielBiegler
Copy link
Author

No, I dont use Qwik. Just wanted to help out and let you know. ✌️

@gioboa
Copy link
Collaborator

gioboa commented Apr 12, 2023

@DanielBiegler I will look at it, thanks 😉

@gioboa gioboa closed this as completed in 6021839 Apr 12, 2023
@gioboa
Copy link
Collaborator

gioboa commented Apr 12, 2023

@DanielBiegler I added a 300ms timeout, can you test the solution pls? I can't reproduce it in my macOS env 😢

@gioboa gioboa reopened this Apr 12, 2023
@DanielBiegler
Copy link
Author

@gioboa Now the reactivity of the subtotal is broken 😆 But thats just a tiny detail.

Afterwards I slowed the network down so you can see what I mean more clearly. Notice how I deselect the input box and it changes on its own after the network finishes loading. This leads to the janky behaviour, even on a good network / local. Debouncing the select-changes would help probably. Disabling the select while it is loading will help too.

Screencast.from.12.04.2023.22.21.41.webm

@gioboa
Copy link
Collaborator

gioboa commented Apr 12, 2023

I solved subtotal update issue. I will investigate in the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants