Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump raw-body version #411

Merged
merged 1 commit into from Jul 22, 2019
Merged

Bump raw-body version #411

merged 1 commit into from Jul 22, 2019

Conversation

thasophearak
Copy link
Contributor

This PR bump raw-body package which contain iconv-lite version that have a fix for

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

timneutkens
timneutkens requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is not needed if it's merged on canary already.

timneutkens
timneutkens approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually as you pointed out in slack this has to be on master and not the canary branch, because that one has to be removed.

@timneutkens timneutkens merged commit bd86cdd into master Jul 22, 2019
@timneutkens timneutkens deleted the update/bump-version-raw-body branch July 22, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thasophearak @timneutkens