From 58ab94bef72f5315fc2ec0a513245f4d0d1a46a5 Mon Sep 17 00:00:00 2001
From: Eungyeol <66717787+eungyeole@users.noreply.github.com>
Date: Fri, 25 Feb 2022 05:04:15 +0900
Subject: [PATCH] feat(create-next-app): add `@types/react-dom` to TS template
 (#34623)

* Add @types/react-dom devDependencies

* fix: eslint error

* fix: eslint error 2
---
 packages/create-next-app/create-app.ts         | 7 ++++++-
 test/integration/create-next-app/index.test.js | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/create-next-app/create-app.ts b/packages/create-next-app/create-app.ts
index be342000dd72..c8cc31f36f04 100644
--- a/packages/create-next-app/create-app.ts
+++ b/packages/create-next-app/create-app.ts
@@ -234,7 +234,12 @@ export async function createApp({
      * TypeScript projects will have type definitions and other devDependencies.
      */
     if (typescript) {
-      devDependencies.push('typescript', '@types/react', '@types/node')
+      devDependencies.push(
+        'typescript',
+        '@types/react',
+        '@types/node',
+        '@types/react-dom'
+      )
     }
     /**
      * Install package.json dependencies if they exist.
diff --git a/test/integration/create-next-app/index.test.js b/test/integration/create-next-app/index.test.js
index bfa14d5ef451..dccbfc22251b 100644
--- a/test/integration/create-next-app/index.test.js
+++ b/test/integration/create-next-app/index.test.js
@@ -143,6 +143,7 @@ describe('create next app', () => {
       expect(Object.keys(pkgJSON.devDependencies)).toEqual([
         '@types/node',
         '@types/react',
+        '@types/react-dom',
         'eslint',
         'eslint-config-next',
         'typescript',