From 71cb54ffa474a883e0fbe0fe557094442ce05351 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20Orb=C3=A1n?= Date: Mon, 12 Dec 2022 23:26:40 +0100 Subject: [PATCH] chore: add repro links in "verify canary" comment (#43979) [Slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1669918824743499) ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) --- .github/actions/issue-validator/canary.md | 2 +- examples/reproduction-template/package.json | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/actions/issue-validator/canary.md b/.github/actions/issue-validator/canary.md index 7abb28b1c5c1f01..5d78d6246ba831a 100644 --- a/.github/actions/issue-validator/canary.md +++ b/.github/actions/issue-validator/canary.md @@ -10,7 +10,7 @@ If the issue does not reproduce with the `canary` version, then it has already b ### **How can I quickly verify if my issue has been fixed in `canary`?** -The safest way is to install `next@canary` in your project and test it, but you can also search through [closed Next.js issues](https://github.com/vercel/next.js/issues?q=is%3Aissue+is%3Aclosed) for duplicates or check the [Next.js releases](https://github.com/vercel/next.js/releases). +The safest way is to install `next@canary` in your project and test it, but you can also search through [closed Next.js issues](https://github.com/vercel/next.js/issues?q=is%3Aissue+is%3Aclosed) for duplicates or check the [Next.js releases](https://github.com/vercel/next.js/releases). You can also use the GitHub [template](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template) (preferred), or the [CodeSandbox](https://codesandbox.io/s/github/vercel/next.js/tree/canary/examples/reproduction-template) or [StackBlitz](https://stackblitz.com/fork/github/vercel/next.js/tree/canary/examples/reproduction-template) templates to create a reproduction with `canary` from scratch. ### **My issue has been open for a long time, why do I need to verify `canary` now?** diff --git a/examples/reproduction-template/package.json b/examples/reproduction-template/package.json index 63e765c6ce94a24..f47d5a6dd9da8fa 100644 --- a/examples/reproduction-template/package.json +++ b/examples/reproduction-template/package.json @@ -11,8 +11,8 @@ "react-dom": "^18.2.0" }, "devDependencies": { - "@types/node": "^18.0.0", - "@types/react": "^18.0.14", - "typescript": "^4.7.4" + "@types/node": "^18.11.13", + "@types/react": "^18.0.26", + "typescript": "^4.9.4" } }