From 869a2fe881d56bf808af3786f160921e337b0220 Mon Sep 17 00:00:00 2001 From: Mohamed Belhadj Date: Thu, 4 Aug 2022 22:36:21 -0400 Subject: [PATCH] Change invalid internal upstream image error code (#39334) fixes #39312 this is more consistent with other errors an invalid image should cause a validation error and not a server error --- packages/next/server/image-optimizer.ts | 2 +- test/integration/image-optimizer/test/util.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/next/server/image-optimizer.ts b/packages/next/server/image-optimizer.ts index 155f994ed496..c6c2267cc322 100644 --- a/packages/next/server/image-optimizer.ts +++ b/packages/next/server/image-optimizer.ts @@ -511,7 +511,7 @@ export async function imageOptimizer( } } else { throw new ImageError( - 500, + 400, 'Unable to optimize image and unable to fallback to upstream image' ) } diff --git a/test/integration/image-optimizer/test/util.js b/test/integration/image-optimizer/test/util.js index e8a7094fd6c8..a972b447202c 100644 --- a/test/integration/image-optimizer/test/util.js +++ b/test/integration/image-optimizer/test/util.js @@ -766,7 +766,7 @@ export function runTests(ctx) { const query = { url, w: ctx.w, q: 39 } const opts = { headers: { accept: 'image/webp' } } const res = await fetchViaHTTP(ctx.appPort, '/_next/image', query, opts) - expect(res.status).toBe(500) + expect(res.status).toBe(400) expect(await res.text()).toBe( `Unable to optimize image and unable to fallback to upstream image` )