From 97ab23fb6f05c4b44c2a14102b2b141ca3ec2e2e Mon Sep 17 00:00:00 2001 From: Jessica Franco Date: Sun, 31 Jul 2022 07:08:50 +0900 Subject: [PATCH] Add missing @napi-rs/cli devDependency to next-swc (#39164) Otherwise build-native fails with "napi: command not found.". Alternatively, this is missing from this package's devDependencies. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) P.S.: local copy fails `pnpm lint` due to the `target` subfolder with intermediate rust build artifacts... should I add a `.prettierignore` update to exclude `/packages/next-swc/target/`? Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com> --- .prettierignore | 4 +++- packages/next-swc/package.json | 3 +++ packages/next/package.json | 2 +- pnpm-lock.yaml | 13 ++++++++----- 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/.prettierignore b/.prettierignore index c8fb26e5e1e7..85f4d4535762 100644 --- a/.prettierignore +++ b/.prettierignore @@ -12,6 +12,8 @@ packages/react-dev-overlay/lib/** lerna.json .github/actions/next-stats-action/.work packages/next-swc/crates/**/* +packages/next-swc/target/**/* +packages/next-swc/native/**/* packages/next-codemod/transforms/__testfixtures__/**/* packages/next-codemod/transforms/__tests__/**/* packages/next-codemod/**/*.js @@ -21,4 +23,4 @@ test-timings.json test/**/out/** bench/nested-deps/pages/**/* bench/nested-deps/components/**/* -pnpm-lock.yaml \ No newline at end of file +pnpm-lock.yaml diff --git a/packages/next-swc/package.json b/packages/next-swc/package.json index 5fa63e85c9e7..2bc63afe62e6 100644 --- a/packages/next-swc/package.json +++ b/packages/next-swc/package.json @@ -24,5 +24,8 @@ "aarch64-pc-windows-msvc" ] } + }, + "devDependencies": { + "@napi-rs/cli": "2.7.0" } } diff --git a/packages/next/package.json b/packages/next/package.json index f75497659702..a974e66a11d0 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -119,7 +119,7 @@ "@babel/types": "7.18.0", "@edge-runtime/primitives": "1.1.0-beta.23", "@hapi/accept": "5.0.2", - "@napi-rs/cli": "2.4.4", + "@napi-rs/cli": "2.7.0", "@napi-rs/triples": "1.1.0", "@next/polyfill-module": "12.2.4-canary.8", "@next/polyfill-nomodule": "12.2.4-canary.8", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index d5413128e9b4..0bfddc53a0f8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -416,7 +416,7 @@ importers: '@babel/types': 7.18.0 '@edge-runtime/primitives': 1.1.0-beta.23 '@hapi/accept': 5.0.2 - '@napi-rs/cli': 2.4.4 + '@napi-rs/cli': 2.7.0 '@napi-rs/triples': 1.1.0 '@next/env': 12.2.4-canary.8 '@next/polyfill-module': 12.2.4-canary.8 @@ -609,7 +609,7 @@ importers: '@babel/types': 7.18.0 '@edge-runtime/primitives': 1.1.0-beta.23 '@hapi/accept': 5.0.2 - '@napi-rs/cli': 2.4.4 + '@napi-rs/cli': 2.7.0 '@napi-rs/triples': 1.1.0 '@next/polyfill-module': link:../next-polyfill-module '@next/polyfill-nomodule': link:../next-polyfill-nomodule @@ -832,7 +832,10 @@ importers: whatwg-fetch: 3.0.0 packages/next-swc: - specifiers: {} + specifiers: + '@napi-rs/cli': 2.7.0 + devDependencies: + '@napi-rs/cli': 2.7.0 packages/react-dev-overlay: specifiers: @@ -4644,8 +4647,8 @@ packages: glob-to-regexp: 0.3.0 dev: true - /@napi-rs/cli/2.4.4: - resolution: {integrity: sha512-f+tvwCv1ka24dBqI2DgBhR7Oxl3DKHOp4onxLXwyBFt6iCADnr3YZIr1/2Iq5r3uqxFgaf01bfPsRQZPkEp0kQ==} + /@napi-rs/cli/2.7.0: + resolution: {integrity: sha512-bQb+r9/xW8LFRbpEN7A/4fX8LnEWbI0JzyOzXGDpO+cI8dXRxX7OPySOpzT2nBgP1brA2Ydkw/t9lyxLN9TlxQ==} engines: {node: '>= 10'} hasBin: true dev: true