From e1083f0e3a729c9ca6ab269ca301bd6050e66c8c Mon Sep 17 00:00:00 2001 From: Shu Uesugi Date: Mon, 27 Jan 2020 05:35:12 -0800 Subject: [PATCH] docs: remove --save from npm install; avoid system-ui (#10252) * Minor edits for CSS doc * Remove unnecessary --save from npm install * Different font family Co-authored-by: Joe Haddad --- docs/basic-features/built-in-css-support.md | 3 ++- docs/getting-started.md | 2 +- examples/with-stencil/packages/test-component/readme.md | 4 ++-- packages/next-bundle-analyzer/readme.md | 2 +- packages/next-mdx/readme.md | 2 +- packages/next/bin/next.ts | 4 ++-- packages/next/server/next-dev-server.ts | 2 +- test/unit/handles-incorrect-react.test.js | 2 +- 8 files changed, 11 insertions(+), 10 deletions(-) diff --git a/docs/basic-features/built-in-css-support.md b/docs/basic-features/built-in-css-support.md index ae832b021f26ec4..1fa7c5f48f36056 100644 --- a/docs/basic-features/built-in-css-support.md +++ b/docs/basic-features/built-in-css-support.md @@ -15,7 +15,8 @@ For example, consider the following stylesheet named `styles.css`: ```css body { - font-family: 'SF Pro Text', 'SF Pro Icons', system-ui; + font-family: 'SF Pro Text', 'SF Pro Icons', 'Helvetica Neue', 'Helvetica', + 'Arial', sans-serif; padding: 20px 20px 60px; max-width: 680px; margin: 0 auto; diff --git a/docs/getting-started.md b/docs/getting-started.md index 6f9c2e716c061fd..64155e039104578 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -20,7 +20,7 @@ The interactive course with quizzes will guide you through everything you need t Install `next`, `react` and `react-dom` in your project: ```bash -npm install --save next react react-dom +npm install next react react-dom ``` Open `package.json` and add the following `scripts`: diff --git a/examples/with-stencil/packages/test-component/readme.md b/examples/with-stencil/packages/test-component/readme.md index 438a2241ee2a7cd..db8c4cca0c49f02 100644 --- a/examples/with-stencil/packages/test-component/readme.md +++ b/examples/with-stencil/packages/test-component/readme.md @@ -61,12 +61,12 @@ Instead, use a prefix that fits your company or any name for a group of related ### Node Modules -- Run `npm install my-component --save` +- Run `npm install my-component` - Put a script tag similar to this `` in the head of your index.html - Then you can use the element anywhere in your template, JSX, html etc ### In a stencil-starter app -- Run `npm install my-component --save` +- Run `npm install my-component` - Add an import to the npm packages `import my-component;` - Then you can use the element anywhere in your template, JSX, html etc diff --git a/packages/next-bundle-analyzer/readme.md b/packages/next-bundle-analyzer/readme.md index 18aa9dedeb1141c..1d2ac2d2f04a912 100644 --- a/packages/next-bundle-analyzer/readme.md +++ b/packages/next-bundle-analyzer/readme.md @@ -5,7 +5,7 @@ Use `webpack-bundle-analyzer` in your Next.js project ## Installation ``` -npm install --save @next/bundle-analyzer +npm install @next/bundle-analyzer ``` or diff --git a/packages/next-mdx/readme.md b/packages/next-mdx/readme.md index 2378f35272b4132..a45f28cef0dee2f 100644 --- a/packages/next-mdx/readme.md +++ b/packages/next-mdx/readme.md @@ -5,7 +5,7 @@ Use [MDX](https://github.com/mdx-js/mdx) with [Next.js](https://github.com/zeit/ ## Installation ``` -npm install --save @next/mdx @mdx-js/loader +npm install @next/mdx @mdx-js/loader ``` or diff --git a/packages/next/bin/next.ts b/packages/next/bin/next.ts index acc1694ff2447e0..6c65b90eac861d4 100755 --- a/packages/next/bin/next.ts +++ b/packages/next/bin/next.ts @@ -7,7 +7,7 @@ import arg from 'next/dist/compiled/arg/index.js' } catch (err) { // tslint:disable-next-line console.warn( - `The module '${dependency}' was not found. Next.js requires that you include it in 'dependencies' of your 'package.json'. To add it, run 'npm install --save ${dependency}'` + `The module '${dependency}' was not found. Next.js requires that you include it in 'dependencies' of your 'package.json'. To add it, run 'npm install ${dependency}'` ) } }) @@ -94,7 +94,7 @@ const React = require('react') if (typeof React.Suspense === 'undefined') { throw new Error( - `The version of React you are using is lower than the minimum required version needed for Next.js. Please upgrade "react" and "react-dom": "npm install --save react react-dom" https://err.sh/zeit/next.js/invalid-react-version` + `The version of React you are using is lower than the minimum required version needed for Next.js. Please upgrade "react" and "react-dom": "npm install react react-dom" https://err.sh/zeit/next.js/invalid-react-version` ) } diff --git a/packages/next/server/next-dev-server.ts b/packages/next/server/next-dev-server.ts index b37f5e3a0cd21a3..c2a30ecf61e3a3b 100644 --- a/packages/next/server/next-dev-server.ts +++ b/packages/next/server/next-dev-server.ts @@ -31,7 +31,7 @@ import checkCustomRoutes from '../lib/check-custom-routes' if (typeof React.Suspense === 'undefined') { throw new Error( - `The version of React you are using is lower than the minimum required version needed for Next.js. Please upgrade "react" and "react-dom": "npm install --save react react-dom" https://err.sh/zeit/next.js/invalid-react-version` + `The version of React you are using is lower than the minimum required version needed for Next.js. Please upgrade "react" and "react-dom": "npm install react react-dom" https://err.sh/zeit/next.js/invalid-react-version` ) } diff --git a/test/unit/handles-incorrect-react.test.js b/test/unit/handles-incorrect-react.test.js index 965f0452a1ca941..32f5d53647b5f90 100644 --- a/test/unit/handles-incorrect-react.test.js +++ b/test/unit/handles-incorrect-react.test.js @@ -11,7 +11,7 @@ const nextBin = path.join(nextDir, 'dist/bin/next') describe('Handles Incorrect React Version', () => { it('should throw an error when building with next', async () => { expect(() => require(nextBin)).toThrow( - /The version of React you are using is lower than the minimum required version needed for Next\.js\. Please upgrade "react" and "react-dom": "npm install --save react react-dom" https:\/\/err\.sh/ + /The version of React you are using is lower than the minimum required version needed for Next\.js\. Please upgrade "react" and "react-dom": "npm install react react-dom" https:\/\/err\.sh/ ) }) })