-
Notifications
You must be signed in to change notification settings - Fork 28.2k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v10.1.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v10.1.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 3 commits
- 50 files changed
- 2 contributors
Commits on Mar 30, 2021
-
Temporarily remove experimental ESLint integration (#23521)
This pull request **temporarily** removes ESLint, as it was not landed in accordance with our standard experimental policies. We are fully committed to landing this change again. This is being reverted because: - Next.js has very strict goals for its install size. This feature resulted in adding over 17MB, or a 43.6% increase. - The feature was not first landed under the `experimental` key in `next.config.js`, rather, it was added under the stable namespace (top-level) - Using the feature doesn't do a "guided setup" like TypeScript, it should ask you to "bring your own" dependencies for ESLint - It uses a undesirable ESLint plugin name: `plugin:@next/next/recommended`. This should read out as strictly `next`, or as short as we can get it. - Does not provide actionable warnings (missing link to resolve issue) - Does not follow appropriate console output styling. We need to revisit how these are presented. To re-land this, we need to ensure the following minimums are met: - Very minor change in install size - Fully experimental (i.e. flagged) with warnings - Finalized package name and configuration shape, preferably so we can do ` { extends: 'next' } `.
Configuration menu - View commit details
-
Copy full SHA for eecc334 - Browse repository at this point
Copy the full SHA eecc334View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1344e2d - Browse repository at this point
Copy the full SHA 1344e2dView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 1ff6057 - Browse repository at this point
Copy the full SHA 1ff6057View commit details
There are no files selected for viewing
This file was deleted.
This file was deleted.