Comparing changes

Bump `react-server-dom-webpack` for support of `experimental_use` API

When a client module is imported by both a module from an `app` entry and a module from `pages` entry, it is possible that it is included in the `pages` chunk eventually. The current check makes the manifest incomplete in that case. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Hello, Just update the docs to be aligned with the current middleware implementation 🙂 Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>

For edge routes in app dir, we passed the page name as url so that the url will be incorrect: * a non-dynamic route `/dashboard` will become `/dashboard/page` * a dynamic route `/dynamic/[id]` with url `/dyanmic/123` will still hit `/dynamic/page/[id]/page` This PR uses normalized `params.page` with interoplated as correct pathname for the page.

This serves to add support for [Subresource Integrity](https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity) hashes for scripts added from the new app directory. This also has support for utilizing nonce values passed from request headers (expected to be generated per request in middleware) in the bootstrapping scripts via the `Content-Security-Policy` header as such: ``` Content-Security-Policy: script-src 'nonce-2726c7f26c' ``` Which results in the inline scripts having a new `nonce` attribute hash added. These features combined support for setting an aggressive Content Security Policy on scripts loaded. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [x] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: Steven <steven@ceriously.com>

…40377) Fixes #40368. ## Bug - [x] Related issues linked using `fixes #number` - [ ] ~~Integration tests added~~ [none applicable] - [ ] ~~Errors have helpful link attached, see `contributing.md`~~ [no new errors]

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

Closes #40366 Rebass is not dependent on `styled-components` anymore. See: https://rebassjs.org/migrating/#v4-breaking-changes Closes #40367 Document has been converted (#39871) from class, so `this.props` threw an error. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Disable this test and investigate it later x-ref: https://github.com/vercel/next.js/runs/8270347830?check_suite_focus=true x-ref: https://github.com/vercel/next.js/runs/8270348185?check_suite_focus=true

## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) The MDX guide is missing `@mdx-js/react` as a required dependency in the setup section. Co-authored-by: JJ Kasper <jj@jjsweb.site>

x-ref: vercel/styled-jsx#813

@huozhi

…uspense (#40397) The PR fixes #40388. Currently, `next/dynamic` will try to provide a default `loading` to the `loadableOptions` even when `suspense` is enabled, thus triggering the incorrect warning. The PR fixes that. The corresponding integration test case is also updated. cc @huozhi ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: huozhi <inbox@huozhi.im>

Added missing trace for `client-full-reload` event in hot reloader. Full reload tests moved to hmr, think they make more sense there than on their own.

An alternative solution to #40371 Ref: #38867, t3-oss/create-t3-app#412, t3-oss/create-t3-app#414 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

This ensures we ignore all except the files/directories we are explicitly wanting to watch to prevent watching/considering directories with massive amounts of files slowing down startup. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: #38483 (comment)

This PR updates the server components documentation to make it more clear the benefit of server components and what their current status is inside Next.js. It removes code snippets and CTAs for trying them out, as things have changed with the Layouts RFC since these docs were previously written. With the upcoming changes, server components will now be the default inside `app`. The list of supported and unsupported features was no longer accurate. We will be providing more guidance as the layouts and routing changes are ready to be tested. [Read the Layouts RFC](https://nextjs.org/blog/layouts-rfc) for more details.

Found that the cause was that `React.useId()` returns the same value across requests whereas it was being used to create a unique key. On further inspection that code could be removed altogether as `id` was not used client-side and the `rscCache` map is no longer needed as the flight instance is already being created per request so it can live in the context of the request execution. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Remove the unused RSC handling for pages in both server router and client side in favor of using RSC in app dir

…40394) See the blog post: https://nextjs.org/blog/next-12-3##swc-minifier-stable ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <jj@jjsweb.site>

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>

This PR update swc crates to swc-project/swc@4c078b0 This PR applies - patches for the performance of minifier - swc-project/swc#5796 - Closes #40399

I was a little confused by the `loading` property having the value `<header />`. I think that property is meant to show a loading state while the file is being loaded? If my assumption is correct, I think this change makes sense.

## Documentation / Examples We now maintain a landing page of all monorepo examples with Next.js apps. We can point users here instead. - [X] Make sure the linting passes by running `pnpm lint` - [X] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

@sokra

### 📖 What's in there? Dynamic code evaluation (`eval()`, `new Function()`, ...) is not supported on the edge runtime, hence why we fail the build when detecting such statement in the middleware or `experimental-edge` routes at build time. However, there could be false positives, which static analysis and tree-shaking can not exclude: - `qs` through these dependencies (get-intrinsic: [source](https://github.com/ljharb/get-intrinsic/blob/main/index.js#L12)) - `function-bind` ([source](https://github.com/Raynos/function-bind/blob/master/implementation.js#L42)) - `has` ([source](https://github.com/tarruda/has/blob/master/src/index.js#L5)) This PR leverages the existing `config` export to let user allow some of their files. it’s meant for allowing users to import 3rd party modules who embed dynamic code evaluation, but do not use it (because or code paths), and can't be tree-shaked. By default, it’s keeping the existing behavior: warn in dev, fails to build. If users allow dynamic code, and that code is reached at runtime, their app stills breaks. ### 🧪 How to test? - (existing) integration tests for disallowing dynamic code evaluation: `pnpm testheadless --testPathPattern=runtime-dynamic` - (new) integration tests for allowing dynamic code evaluation: `pnpm testheadless --testPathPattern=runtime-configurable` - (amended) production tests for validating the new configuration keys: `pnpm testheadless --testPathPattern=config-validations` To try it live, you could have an application such as: ```js // lib/index.js /* eslint-disable no-eval */ export function hasUnusedDynamic() { if ((() => false)()) { eval('100') } } export function hasDynamic() { eval('100') } // pages/index.jsx export default function Page({ edgeRoute }) { return <p>{edgeRoute}</p> } export const getServerSideProps = async (req) => { const res = await fetch(`http://localhost:3000/api/route`) const data = await res.json() return { props: { edgeRoute: data.ok ? `Hi from the edge route` : '' } } } // pages/api/route.js import { hasDynamic } from '../../lib' export default async function handle() { hasDynamic() return Response.json({ ok: true }) } export const config = { runtime: 'experimental-edge' , allowDynamic: '/lib/**' } ``` Playing with `config.allowDynamic`, you should be able to: - build the app even if it uses `eval()` (it will obviously fail at runtime) - build the app that _imports but does not use_ `eval()` - run the app in dev, even if it uses `eval()` with no warning ### 🆙 Notes to reviewers Before adding documentation and telemetry, I'd like to collect comments on a couple of points: - the overall design for this feature: is a list of globs useful and easy enough? - should the globs be relative to the application root (current implementation) to to the edge route/middleware file? - (especially to @sokra) is the implementation idiomatic enough? I've leverage loaders to read the _entry point_ configuration once, then the ModuleGraph to get it back during the parsing phase. I couldn't re-use the existing `getExtractMetadata()` facility since it's happening late after the parsing. - there's a glitch with `import { ServerRuntime } from '../../types'` in `get-page-static-info.ts` ([here](https://github.com/vercel/next.js/pull/39539/files#diff-cb7ac6392c3dd707c5edab159c3144ec114eafea92dad5d98f4eedfc612174d2L12)). I had to use `next/types` because it was failing during lint. Any clue why? ### ☑️ Checklist - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [x] Telemetry added. In case of a feature if it's used or not. - [x] Errors have helpful link attached, see `contributing.md`

Follow-up to #39539 as discussed this renames to `unstable_` prefix initially while we test this out further. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Such bots typically navigate websites using hard navigations (as they crawl one URL at a time). Respectively, they do not benefit from prefetches at all, while increasing the cost of both the crawl and operating the site.  ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`

…40491) ## Summary This PR adds a note about how to see the data that this error is complaining about: ```sh Warning: data for page "/" is xxx which exceeds the threshold of 128 kB, this amount of data can reduce performance. ``` This debug trick was something I came across in a [discussion](#39880) and I thought it would be helpful to others like it was for me. ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>

Made an addition to the version history within the Script component docs. In the docs there are examples where the Script component is being used within a _document.js/tsx file, but it does not get mentioned that this is only supported from version 12.2.2 onwards. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` Co-authored-by: JJ Kasper <jj@jjsweb.site>

## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <jj@jjsweb.site>

`eslint-plugin-react` has a broken version between v7.31.2-6. Upping the version range ensure that only functioning packages get installed. Fixes #40245 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>

Closes #40497 Ref: https://pnpm.io/cli/link, https://stackoverflow.com/a/70266777 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: Balázs Orbán <info@balazsorban.com>

Ref: #40501

- Use React.startTransition instead of useTransition - Upgrade to latest React experimental - Split router cache invalidate into separate function Some minor cleanup while verifying behaviors.

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>

@Nutlope

This PR follows #40181, adding the dark mode support for the brand new Next.js logo (BTW, the new logo is awesome!). The dark version of the logo is also served from `assets.vercel.com` (I just change the original logo URL, replace the `light` with `dark`, and surprisingly find out that doesn't result in 404). cc @Nutlope @steven-tey Ref: [Specify theme context for images in Markdown (Beta) - GitHub Blog](https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/) Currently, the Next.js README in dark mode: <img width="917" alt="image" src="https://user-images.githubusercontent.com/40715044/188449078-864f6b71-7741-44f4-aee6-02a281b0a263.png"> After the PR: <img width="914" alt="image" src="https://user-images.githubusercontent.com/40715044/188449265-a3556565-d866-4e0e-9b97-be62fba6c6fe.png"> Preview link: https://github.com/SukkaW/next.js/tree/readme-logo-darkmode

As pointed out in #40389 (comment), the `filter` matched more files than necessary and merged different example directories together. This change makes the filter match the example directory name precisely. Fixes #40389 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Consume the original sourcemap in flight client loader if there's any, to avoid source map is generated based on the module proxy which make debugging hard Testing with adding `debugger` in layout router, screenshot: <img width="400" alt="image" src="https://user-images.githubusercontent.com/4800338/189866388-adb1aba5-496b-4b8d-8098-ec04d6f1914a.png">

Adds some of the tests we didn't have yet for app.  ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

## Info This PR merges with-mobx-lite into with-mobx. After that we will migrate `with-mobx` to typescript. ## Context As discussed in #40302 (comment) we are going to merge the mobx examples. #40302 ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Another step toward fixing #40025. Multiple `next/script` components with the same `src` may exist in the Next.js app. So the `loadScript` function will always attach the `onLoad` handler to the `loadingPromise` every time it executes. However, with strict mode (or wrapped inside the `<OffScreen />` component), the `useEffect` could execute more than once for the same `next/script` component, thus the `loadScript` for each `next/script` component could execute more than once (and `onLoad` to be attached more than once), results in `onLoad` fires more than once. The PR makes sure that for every `next/script` component mounted, the `loadScript` will always be executed only once for each of them. The corresponding `onload fires correctly` integration test case is also updated to run in dev mode. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`

Small changes: - Group parallel routes tests - Upgrade tests to latest react experimental

…rod (#40541) Ref: #40002 #40026 #40191 Fixes #40025 This is the final step of fixing #40025. The PR migrates the rest of the `next/script` test cases to run in both dev (strict mode) and production, confirming that the `next/script` component is now completely concurrent rendering resilient and is ready for the upcoming React 18 `<OffScreen />`. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`

This upgrades @makeswift/runtime to the latest version, which adds support for the Slot control. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

-Original file line number
+Diff line change
@@ @@ -4,6 +4,7 @@ @@
     *          @timneutkens @ijjk @shuding @huozhi
     /.github/  @timneutkens @ijjk @shuding @styfle @huozhi @padmaia @balazsorban44
     /docs/     @timneutkens @ijjk @shuding @styfle @huozhi @padmaia @leerob @balazsorban44
+    /errors/   @balazsorban44
     /examples/ @timneutkens @ijjk @shuding @leerob @steven-tey @balazsorban44
     # SWC Build & Telemetry (@padmaia)

-Original file line number
+Diff line change
@@ @@ -9,92 +9,81 @@ @@
           "type": "node",
           "request": "launch",
           "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "debug-react-exp", "dev", "test/e2e/app-dir/app"],
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["debug-react-exp", "dev", "test/e2e/app-dir/app"],
           "skipFiles": ["<node_internals>/**"],
-          "outFiles": ["${workspaceFolder}/packages/next/dist/**/*"],
-          "port": 9229,
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
           "name": "Launch app development",
           "type": "node",
           "request": "launch",
           "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "debug", "dev", "bench/nested-deps"],
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["debug", "dev", "examples/hello-world"],
           "skipFiles": ["<node_internals>/**"],
-          "outFiles": ["${workspaceFolder}/packages/next/dist/**/*"],
-          "port": 9229,
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
           "name": "Launch app build",
           "type": "node",
           "request": "launch",
           "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "debug", "build", "bench/nested-deps"],
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["debug", "build", "examples/hello-world"],
           "skipFiles": ["<node_internals>/**"],
-          "port": 9229,
-          "outFiles": ["${workspaceFolder}/packages/next/dist/**/*"],
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
-          "name": "Launch app build trace jaeger",
+          "name": "Launch app production",
           "type": "node",
           "request": "launch",
           "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "clean-trace-jaeger"],
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["debug", "start", "examples/hello-world"],
           "skipFiles": ["<node_internals>/**"],
-          "port": 9229,
-          "outFiles": ["${workspaceFolder}/packages/next/dist/**/*"],
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
-          "name": "Launch app production",
+          "name": "Launch current directory in development",
           "type": "node",
           "request": "launch",
           "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "debug", "start", "bench/nested-deps"],
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["debug", "dev", "${fileDirname}"],
           "skipFiles": ["<node_internals>/**"],
-          "port": 9229,
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
+          "name": "Launch app build trace jaeger",
           "type": "node",
-          "request": "attach",
-          "name": "Attach to existing debugger",
-          "port": 9229,
+          "request": "launch",
+          "cwd": "${workspaceFolder}",
+          "runtimeExecutable": "pnpm",
+          "runtimeArgs": ["clean-trace-jaeger"],
           "skipFiles": ["<node_internals>/**"],
-          "outFiles": ["${workspaceFolder}/packages/next/dist/**/*"],
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         },
         {
-          "name": "Launch this example",
           "type": "node",
-          "request": "launch",
-          "cwd": "${workspaceFolder}",
-          "runtimeExecutable": "yarn",
-          "runtimeArgs": ["run", "debug", "dev", "${fileDirname}"],
-          "skipFiles": ["<node_internals>/**"],
+          "request": "attach",
+          "name": "Attach to existing debugger",
           "port": 9229,
+          "skipFiles": ["<node_internals>/**"],
           "env": {
-            "NEXT_PRIVATE_LOCAL_WEBPACK5": "1"
+            "NEXT_PRIVATE_LOCAL_WEBPACK": "1"
           }
         }
       ]

-Original file line number
+Diff line change
@@ -1,11 +1,11 @@
     {
       "scripts": {
         "prepare": "rimraf components && mkdir components && node ./fuzzponent.js -d 2 -s 206 -o components",
-        "dev": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 node ../../node_modules/next/dist/bin/next dev",
-        "build": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 node ../../node_modules/next/dist/bin/next build",
-        "start": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 node ../../node_modules/next/dist/bin/next start",
+        "dev": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK=1 node ../../node_modules/next/dist/bin/next dev",
+        "build": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK=1 node ../../node_modules/next/dist/bin/next build",
+        "start": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK=1 node ../../node_modules/next/dist/bin/next start",
         "dev-nocache": "rimraf .next && yarn dev",
-        "dev-cpuprofile-nocache": "rimraf .next && cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 node --cpu-prof ../../node_modules/next/dist/bin/next",
+        "dev-cpuprofile-nocache": "rimraf .next && cross-env NEXT_PRIVATE_LOCAL_WEBPACK=1 node --cpu-prof ../../node_modules/next/dist/bin/next",
         "build-nocache": "rimraf .next && yarn build"
       },
       "devDependencies": {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comparing changes

Open a pull request

Commits on Sep 8, 2022

Commits on Sep 9, 2022

Commits on Sep 11, 2022

Commits on Sep 12, 2022

Commits on Sep 13, 2022

Commits on Sep 14, 2022

There are no files selected for viewing

-Original file line number
+Diff line change
@@ -1,14 +1,14 @@
     <!--
     Thanks for opening a PR! Your contribution is much appreciated.
-    In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
+    To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
     Choose the right checklist for the change that you're making:
     -->
     ## Bug
     - [ ] Related issues linked using `fixes #number`
     - [ ] Integration tests added
-    - [ ] Errors have helpful link attached, see `contributing.md`
+    - [ ] Errors have a helpful link attached, see `contributing.md`
     ## Feature
@@ @@ -17,9 +17,9 @@ Choose the right checklist for the change that you're making: @@
     - [ ] Integration tests added
     - [ ] Documentation added
     - [ ] Telemetry added. In case of a feature if it's used or not.
-    - [ ] Errors have helpful link attached, see `contributing.md`
+    - [ ] Errors have a helpful link attached, see `contributing.md`
     ## Documentation / Examples
     - [ ] Make sure the linting passes by running `pnpm lint`
-    - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
+    - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)