-
Notifications
You must be signed in to change notification settings - Fork 27.9k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v13.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v13.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 15 commits
- 158 files changed
- 8 contributors
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12a6827 - Browse repository at this point
Copy the full SHA 12a6827View commit details -
Fix serving images referenced from app directory (#49236)
### What? Fixes serving images that are referenced by JS files inside the `/app` directory. ### Why? ### How? The `NextImageContentSource` attempts to fetch the image out of it's inner content source, and before we were only providing it with the `/public` and `/pages` directory's respective sources. Re: https://vercel.slack.com/archives/C046HAU4H7F/p1683220799917649
Configuration menu - View commit details
-
Copy full SHA for d24f506 - Browse repository at this point
Copy the full SHA d24f506View commit details -
Update dev logs to include request timings (#49191)
This updates our dev logs to include request timings and also includes fetch timings in app directory to including info on whether the cache was leveraged or not allowing easier debugging of contributing factors to render times. In the future we can expand to include middleware timings separate as well to single that out along with timings for `getStaticProps` potentially as well. <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> <details> <summary>Screenshot</summary>  </details> x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1681418590738249)
Configuration menu - View commit details
-
Copy full SHA for 30f84e3 - Browse repository at this point
Copy the full SHA 30f84e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for acd2280 - Browse repository at this point
Copy the full SHA acd2280View commit details -
Support incrementalCacheHandlerPath for standalone output (#48694)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change --> ### What? This is a follow-up to #46290 by @ijjk Currently, nextjs build resolves provided incrementalCacheHandlerPath over destDir (.next by default). And for standalone builds the custom cache can't be resolved and leads to runtime error. ### Why? This fix basically introduces support of incrementalCacheHandlerPath for the standalone build. ### How? incrementalCacheHandlerPath is now always resolved relatively to distDir, which should work for both default and standalone builds. Also, for convenience (and better testability) incrementalCacheHandlerPath can now be provided as a relative path to the project directory.
Configuration menu - View commit details
-
Copy full SHA for 7f6e8db - Browse repository at this point
Copy the full SHA 7f6e8dbView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 7fa4946 - Browse repository at this point
Copy the full SHA 7fa4946View commit details -
Fix Server Actions defined in both layers in one entry (#49248)
This fixes an existing bug where there're Server Actions defined in both the "server" and "client" layers (client imported Actions). They have the same worker name as they exist in one route entry, but they're built into different modules and compiled differently (server and client layers). Because of that, each route entry can have 2 "action module entries". This PR adds the logic to differentiate that via a "layer" field so they don't conflict.
Configuration menu - View commit details
-
Copy full SHA for bf49f62 - Browse repository at this point
Copy the full SHA bf49f62View commit details -
Update tags handling during server action redirect (#49227)
Updates the tag handling during a server action direct to pass through the revalidated tags for immediate revalidation as discussed. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759)
Configuration menu - View commit details
-
Copy full SHA for 0bf6c27 - Browse repository at this point
Copy the full SHA 0bf6c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for d37043f - Browse repository at this point
Copy the full SHA d37043fView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for fd319d3 - Browse repository at this point
Copy the full SHA fd319d3View commit details
Commits on May 5, 2023
-
Add experimental verbose logging flag (#49250)
Only shows fetch request logs by default and allows opting into verbose request timings via experimental config. x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1683236293282549)
Configuration menu - View commit details
-
Copy full SHA for c881224 - Browse repository at this point
Copy the full SHA c881224View commit details -
Remove experimental config from create-next-app (#49241)
## What? Removes `experimental.appDir` this was leftover from when I flipped the switch. Kept the config file as in the future we might add future flags and such. It also helps that it has the types comment included so you always get types. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
Configuration menu - View commit details
-
Copy full SHA for 25a9547 - Browse repository at this point
Copy the full SHA 25a9547View commit details -
Configuration menu - View commit details
-
Copy full SHA for 618dc2e - Browse repository at this point
Copy the full SHA 618dc2eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 2c37ec0 - Browse repository at this point
Copy the full SHA 2c37ec0View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 92ff2dd - Browse repository at this point
Copy the full SHA 92ff2ddView commit details
There are no files selected for viewing