Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
63
contributors
Commits on Jun 10, 2023
-
Fix getting last stable release stats (#51106)
Small fix ensuring we use the correct repo for getting the last stable tag
-
Commits on Jun 11, 2023
-
ci(workflow): consolidate bytesize upload workflow (#51110)
### What? context: https://github.com/vercel/next.js/actions/runs/5231928600/jobs/9446394605#step:16:33 For some reason, installing datadog cli on some action runner (Windows) is unexpectedly slow: while other platform takes ~30s, windows only takes more than > 7m. PR updates workflow logic to consolidate artifacts, and then send metrics at once on a separate ubuntu workflow.
-
Do not merge chunkGroups' CSS files (#51103)
This is a temporary fix before we can ship #51018 (more details there). If there're multiple chunk groups holding the same CSS module, we use files from the first one. This has some flaws but still better than our current status.
-
Commits on Jun 12, 2023
-
Add unique search query for RSC requests to be cacable on CDN (#50970)
Adding a `_rsc` query for RSC payload requests so that they can be differentiated on resources level for CDN cache for the ones that didn't fully respect to VARY header. Also stripped them for node/edge servers so that they won't show up in the url x-ref: #49140 (comment) Closes #49140 Closes NEXT-1268
-
-
Update next-image-unconfigured-host.md with correct Remote Patterns D…
…ocumentation link to new docs (#49750)
-
-
-
add turbopack integration tests to CI (#50904)
### What? * enable turbopack tests in new CI * split pre-build step into native and JS builds to allow to start native tests faster * update swc_core to sync with turbo * update turbopack ### Why? Running our test suite is still important as long we don't have the full integration test suite enabled. ### Turbopack updates * vercel/turborepo#5215 <!-- OJ Kwon - ci(workflow): upload benchmark results to datadog --> * vercel/turborepo#5239 <!-- OJ Kwon - fix(swc_plugin): use shared runtime --> * vercel/turborepo#3090 <!-- CHEN Yuan - Docs: prior to run testcases, add guides to install dependencies for testcases. --> * vercel/turborepo#5264 <!-- Tobias Koppers - update test runner --> --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
-
docs: Improve Actions docs. (#51145)
Adds more clarity on which pieces are Next.js only, how actions integrate with Next.js, and details on the progressive enhancement story.
-
docs: clarify
usePathnameusage as client hook. (#51146)Using client components for `usePathname` is not a de-optimization. This update tries to make this more clear by sharing more information about the design and tradeoffs of this approach. --------- Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Add option for debugging CPU usage (#51174)
Add a `NEXT_CPU_PROF` environment variable to programmatically profile CPU for the router worker and two render workers. This is helpful because the `--cpu-prof` isn't reliably writing the result (#27406) especially with our multi-process architecture. 
-
-
ci(workflow): enable test trace upload (#51107)
### What? WEB-1150. This PR is an attempt to upload next.js's test results into datadog test trace to track its status. Originally it tried to use automatic trace injection (dd-trace/ci/init). However, due to some of custom environments / setup we use it was not compatible out of the box. Instead, this PR injects a new test reportert to generate junit report, then upload it at once at the end of the testing pipeline. The reporter is configured to run when necessary variables set, local run should not be affected. One thing to note is this report will not count retry results, as it'll create duplicated test entry with multiple results since we runts jest per individual test. This'll allow to detect flaky test easier, but also it means we'll get bit of skewed test results compare to the real world as first failure will be accounted as test fail immediately.
-
Prefer module fields for RSC server layer (#51179)
Follow up for #50548 There're some packages like `aws-sdk-js-v3` which doesn't have a exports field yet: ``` "main": "./dist-cjs/index.js", "types": "./dist-types/index.d.ts", "module": "./dist-es/index.js", ``` This PR let u pick up by the js assets based on main fields, will prefer `"module"` field instead of `"main"` Closes NEXT-1286
-
[Docs] Update static assets page to filter out <PagesOnly> information (
#51180) Co-authored-by: Michael Novotny <446260+manovotny@users.noreply.github.com>
-
Makes codeblock language and filename extensions consistent (#51056)
There was mismatched usage of `js`, `jsx`, `ts`, and `tsx`. Just tried to get them all in sync.
-
fix: helpful error when
output: exportandnext export -o(#51191)We already have a warning when using `next export` with `output: export` because the `next export` is effectively a no-op (the exported output was already generated during `next build`). However, this PR ensures that `next export -o <dir>` throws an error when `output: export` is defined because the files were already emitted to the `distDir` in the `next build` step and we can't safely no-op at this point. We also guide the user to the correct solution which is to use `output: export` along with `distDir: <dir>` in your next.config.js (instead of mixing legacy behavior with the new behavior). fix #48207 fix NEXT-980
-
Strip _rsc query for navigation between app and page (#51195)
Fix a missing case from #50970 When navigating from app to page, the `_rsc` query should still be stripped
-
-
Fix a mistake URL in "docs/generate-metadata.mdx/metadataBase" (#51199)
The sample output of `metadataBase` configuration (`<head <link rel="alternate" ...>`) had an incorrect `href`: https://nextjs.org/docs/app/api-reference/functions/generate-metadata#metadatabase
-
-
docs: correct valid route segments for icon/favicon/apple-icon (#51188)
Improves the documentation to correctly mention that only favicon is restricted to the root app/ segment. x-ref: [slack](https://vercel.slack.com/archives/C03KAR5DCKC/p1686425241975119)
-
Commits on Jun 13, 2023
-
docs: Adds
NotetoGood to knowconsistency (#51080)* Changes all `Note` → `Good to know` * Consistently puts the colon on the outside of bold text * Documents singe and multi-line styles in contribution guide --------- Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
[docs] Add missing Edge Runtime APIs (#51224)
Added missing APIs, also sorted all of them alphabetically to make it easier to read. --------- Co-authored-by: Delba de Oliveira <delbabrown@gmail.com>
-
-
[Docs] fix example function param and signature (#51235)
Apparently the object deconstruction in the example doesn't work. This PR proposes a working version: ```diff - export default function Page({ params: { slug: string } }) { - return <div>My Post: {slug}</div> - } + export default function Page({ params }: { params: { slug: string } }) { + return <div>My Post: {params.slug}</div> + } ``` According to the [page reference](https://nextjs.org/docs/app/api-reference/file-conventions/page), the page function parameter slugs needs to be retrieved by calling `params.slug`. The TypeScript section below shows the correct function type signature, although not referencing to the parameter. -
[Docs] Remove extra line in summary dropdowns (#51226)
They were causing markdown to render a <p> tag which has margins and broke the summary dropdowns
-
-
I found some 404 links in jsdoc, so I used ripgrep to find and fix all the broken links to fix all the other links in this PR.
-
[Docs] Recommend
prettier-fixin PR template and contribution guide (……#51237) Recommend running `prettier-fix` before opening docs PRs to fix formatting issues. I've found that `lint-fix` is currently not fixing formatting issues. Related: https://vercel.slack.com/archives/C03S9JCH2Q5/p1686647582580629
-
ci(workflow): skip test trace upload when test skips (#51190)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? Attempt to fix workflow to skip trace upload if test skips.
-
Simplify the client manifest structure (#51183)
Both of our bundlers won't split different exports of a module into different chunks, we can rely on facebook/react#26624 to simplify the structure. This reduces the size of the client reference manifest by ~70%.
-
Add buildId into RSC payload (#50974)
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
-
Turbopack: remove
__internal_nextjs_integration_testcompile-time f……eature (#51204) This removes the `__internal_nextjs_integration_test` compile-time feature. This would end up requiring an additional set of build targets for running integration tests was only used for two cases: * Determining whether to read from an env var to load mocked Google fonts responses in next/font/google tests. This now uses the presence of this variable to determine whether to use mocked responses. * Enabling the `next-dev/serializable` feature. This is now set directly instead. Test Plan: * Integration tests with Turbopack. * Manual test of next/font/google with Turbopack
-
-
Tweak code owners after some testing and feedback. - Move the Next.js team up to be optional global code owners (so that everyone can review but are not tagged for review). Global individuals should still be tagged if there are no specific `.vercel.approvers` files in subdirectories. - Adds @vercel/devex to image files so there's coverage on those files for the docs - Target specific folder and files for Styfle to get notified - Deletes some rules in the old GitHub codeowners
-
-
Fix broken link in client-side rendering page
-
Adds homepage to
eslint-config-nextpackage (#51059)Fixes (partially) #50843. --------- Co-authored-by: Steven <steven@ceriously.com> Co-authored-by: JJ Kasper <jj@jjsweb.site>
3 people authoredJun 13, 2023
There are no files selected for viewing