Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Relay Modern example #10150

Merged
merged 4 commits into from Jan 20, 2020
Merged

Update Relay Modern example #10150

merged 4 commits into from Jan 20, 2020

Conversation

thibaultboursier
Copy link
Contributor

@thibaultboursier thibaultboursier commented Jan 18, 2020 •
edited

Relay Modern example, which is located in folder ./examples/with-relay-modern, needed to be updated.

Here is what I did for this PR.

1. Dependencies update

A lot of dependencies were out-of-date (relay-compiler, react-relay, ...).
I have updated them to their most recent version, making sure there is no incompatibility.

2. Build error fixing

A build error occurred, because generated Relay folder is inside pages folder. This issue is referenced in several places (#8617, ...).
Rather changing build configuration, I simply extracted the GraphQL query from the page, to place it in a queries folder.

3. Syntax improvement

  • I changed Index class component to a functional component.
  • I removed some useless key prop.
  • I used implicit return for some components.

I would like, in a future PR, to improve the graphic style of this example, as well as to improve the example with, for example, the use of QueryRenderer.

@ijjk
Copy link
Member

ijjk commented Jan 18, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
buildDuration 13.5s 13.6s ⚠️ +102ms
nodeModulesSize 48.9 MB 48.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..8249.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.08 kB 3.08 kB ✓
Serverless Mode
General
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
buildDuration 14s 14.2s ⚠️ +221ms
nodeModulesSize 48.9 MB 48.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..8249.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary thibaultboursier/next.js update-relay-modern-example Change
_error.js gzip 70.9 kB 70.9 kB ✓
hooks.html gzip 1.06 kB 1.06 kB ✓
index.js gzip 71.3 kB 71.3 kB ✓
link.js gzip 80.6 kB 80.6 kB ✓
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB ✓

Commit: aff90cd

Timer
Timer approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer added this to the 9.2.1 milestone Jan 20, 2020
@Timer Timer added ready to land examples Issue/PR related to examples labels Jan 20, 2020
@Timer Timer merged commit 71e29cd into vercel:canary Jan 20, 2020
This was referenced Feb 18, 2020
Closed
Open
@messa messa mentioned this pull request Mar 11, 2020
Merged
@thibaultboursier thibaultboursier deleted the update-relay-modern-example branch November 17, 2021 17:21
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thibaultboursier @ijjk @Timer