Add support for catch-all routes with SSG #10175

ijjk · 2020-01-20T19:14:07Z

This updates our validating in build/utils to handle catch-all routes for getStaticPaths values and adds tests for catch-all behavior with SSG.

Note: this currently works if you only return the paths as strings from unstable_getStaticPaths instead of using the { params: { slug: [ 'value' ] } } variant

Fixes: #10173

ijjk · 2020-01-20T19:20:42Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
buildDuration	13.5s	13.3s	-181ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +721 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..fffc.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.js gzip	1.34 kB	1.34 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.module.js gzip	769 B	769 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.42 kB	7.42 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
buildDuration	14.2s	13.9s	-293ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +721 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..fffc.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.js gzip	1.34 kB	1.34 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.module.js gzip	769 B	769 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.42 kB	7.42 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_error.js gzip	70.9 kB	70.9 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	71.3 kB	71.3 kB	✓
link.js gzip	80.6 kB	80.6 kB	✓
routerDirect.js gzip	78.2 kB	78.2 kB	✓
withRouter.js gzip	78.3 kB	78.3 kB	✓
Overall change	380 kB	380 kB	✓

Commit: 5512833

Timer

Please add a test for the error message when a user passes a string to catch-all route param.

…sg/catchall-support

ijjk · 2020-01-20T21:34:01Z

Added a test for invalid catchall param in getStaticPaths

ijjk · 2020-01-20T21:40:00Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
buildDuration	13s	13.1s	⚠️ +73ms
nodeModulesSize	48.8 MB	48.8 MB	⚠️ +721 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.js gzip	5.12 kB	5.12 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c512.js gzip	16.3 kB	16.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.js gzip	1.34 kB	1.34 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.module.js gzip	769 B	769 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.42 kB	7.42 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
buildDuration	13.6s	13.7s	⚠️ +99ms
nodeModulesSize	48.8 MB	48.8 MB	⚠️ +721 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.js gzip	5.12 kB	5.12 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c512.js gzip	16.3 kB	16.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	70 kB	70 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.7 kB	64.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.js gzip	1.34 kB	1.34 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_app.module.js gzip	769 B	769 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.42 kB	7.42 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js ssg/catchall-support	Change
_error.js gzip	70.9 kB	70.9 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	71.3 kB	71.3 kB	✓
link.js gzip	80.6 kB	80.6 kB	✓
routerDirect.js gzip	78.2 kB	78.2 kB	✓
withRouter.js gzip	78.3 kB	78.3 kB	✓
Overall change	380 kB	380 kB	✓

Commit: 3ef2a4c

Add support for catchall routes with SSG

5512833

ijjk added this to the ssg milestone Jan 20, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners January 20, 2020 19:14

Merge branch 'canary' into ssg/catchall-support

95fd69b

Timer requested changes Jan 20, 2020

View reviewed changes

ijjk added 4 commits January 20, 2020 15:29

Merge remote-tracking branch 'upstream/canary' into ssg/catchall-support

59afc3a

Merge branch 'ssg/catchall-support' of github.com:ijjk/next.js into s…

544a70c

…sg/catchall-support

Add test for invalid catchall param in getStaticPaths

d69e108

Merge remote-tracking branch 'upstream/canary' into ssg/catchall-support

3ef2a4c

ijjk requested a review from Timer January 20, 2020 21:34

Timer approved these changes Jan 20, 2020

View reviewed changes

Timer added priority: low kind: bug Confirmed bug that is on the backlog labels Jan 20, 2020

Timer merged commit 5f5c5e4 into vercel:canary Jan 20, 2020

Timer deleted the ssg/catchall-support branch January 20, 2020 21:44

This was referenced Feb 18, 2020

[Snyk] Upgrade next from 9.1.2 to 9.2.1 ndom91/newtelco-next-maintenance-mgmt#22

Closed

[Snyk] Upgrade next from 9.1.1 to 9.2.1 tinkerbox/mailyard-spa#10

Open

Timer modified the milestones: ssg, 9.3.0 Mar 9, 2020

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for catch-all routes with SSG #10175

Add support for catch-all routes with SSG #10175

ijjk commented Jan 20, 2020 •

edited

ijjk commented Jan 20, 2020

Timer left a comment

ijjk commented Jan 20, 2020

ijjk commented Jan 20, 2020

Add support for catch-all routes with SSG #10175

Add support for catch-all routes with SSG #10175

Conversation

ijjk commented Jan 20, 2020 • edited

ijjk commented Jan 20, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jan 20, 2020

ijjk commented Jan 20, 2020

Stats from current PR

ijjk commented Jan 20, 2020 •

edited