Skip to content

Add error for invalid distDir value #10177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2020
Merged

Add error for invalid distDir value #10177

merged 5 commits into from
Jan 20, 2020
+56 −28

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 20, 2020

If this value is an empty string it results in the distDir being the same as the application's directory which can have bad side-effects and is not valid

Closes: #10135

@ijjk
Add error for invalid distDir value

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6CFC4C3DAD69C3E4
Learn about vigilant mode
011718b
@ijjk ijjk added this to the 9.2.x milestone Jan 20, 2020
lfades
lfades approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Timer
Timer requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just default empty string to .next?

@ijjk
Copy link
Member Author

ijjk commented Jan 20, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 14s 13.6s -419ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.15 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/checking-distDir Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.06 kB 3.06 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 14.6s 14.5s -14ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.15 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_error.js gzip 70.9 kB 70.9 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 71.3 kB 71.3 kB ✓
link.js gzip 80.6 kB 80.6 kB ✓
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB ✓

Commit: 011718b

@timneutkens
Copy link
Member

timneutkens commented Jan 20, 2020 •
edited
Loading

@Timer because it's invalid configuration, I asked JJ to add the error.

'' refers to an actual value, so changing that to '.next' would be unexpected.

@ijjk ijjk requested a review from Timer January 20, 2020 20:14
@Timer Timer modified the milestones: 9.2.x, 9.2.1 Jan 20, 2020
@Timer
Merge branch 'canary' into add/checking-distDir

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
765ff01
@ijjk
Copy link
Member Author

ijjk commented Jan 20, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 12.9s 13s ⚠️ +29ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.15 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/checking-distDir Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.06 kB 3.06 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 13.5s 13.5s -24ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.15 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_error.js gzip 70.9 kB 70.9 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 71.3 kB 71.3 kB ✓
link.js gzip 80.6 kB 80.6 kB ✓
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB ✓

Commit: 765ff01

ijjk added 2 commits January 20, 2020 14:23
@ijjk
Merge remote-tracking branch 'upstream/canary' into add/checking-distDir

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6CFC4C3DAD69C3E4
Learn about vigilant mode
2c2ea6c
@ijjk
Add check for null/undefined distDir

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6CFC4C3DAD69C3E4
Learn about vigilant mode
5a2128a
@ijjk ijjk requested a review from Timer January 20, 2020 20:27
@ijjk
Merge branch 'add/checking-distDir' of github.com:ijjk/next.js into a…

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6CFC4C3DAD69C3E4
Learn about vigilant mode
1c2f155 
…dd/checking-distDir
@ijjk
Copy link
Member Author

ijjk commented Jan 20, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 14.6s 14.6s -36ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.28 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/checking-distDir Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.06 kB 3.06 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/checking-distDir Change
buildDuration 15.5s 15.6s ⚠️ +101ms
nodeModulesSize 48.8 MB 48.8 MB ⚠️ +1.28 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c512.js gzip 16.3 kB 16.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 70 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.7 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/checking-distDir Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/checking-distDir Change
_error.js gzip 70.9 kB 70.9 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 71.3 kB 71.3 kB ✓
link.js gzip 80.6 kB 80.6 kB ✓
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB ✓

Commit: 1c2f155

@ijjk ijjk merged commit a21a8fc into vercel:canary Jan 20, 2020
@ijjk ijjk deleted the add/checking-distDir branch January 20, 2020 20:35
This was referenced Feb 18, 2020
Closed
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer

@lfades lfades

@timneutkens timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.1
Development

Successfully merging this pull request may close these issues.

Directory files have been deleted and have occurred many times.
4 participants
@ijjk @timneutkens @Timer @lfades