Stabilize New Dev Test #10188
Merged
Stabilize New Dev Test #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
approved these changes
Jan 21, 2020
ijjk
reviewed
Jan 21, 2020
| @@ -74,7 +75,8 @@ const noError = async (pathname, click = false) => { | |||
| }) | |||
| window.next.router.replace('${pathname}') | |||
| })()`) | |||
| await waitFor(250) | |||
| // wait for page to be built and navigated to | |||
| await waitFor(3000) | |||
There was a problem hiding this comment.
We should probably look into adding a didHydration callback or something for testing instead of trying to waiting for an arbitrary amount of time 🤔
ijjk
approved these changes
Jan 21, 2020
This was referenced Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix the following error:
Currently breaking PRs: #10186, #10187, etc.