Revert "feat(build): Transpile assuming higher version of runtime" #10233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 6b87b2b.
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 94ee7b4 |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: c7e0b90 |
|
|
Transform runtime will only attempt to polyfill Since the default is below the above tested range, they're never polyfilled even if used:
This is referring specifically to the above behavior, that Next.js wouldn't polyfill the Read on: Unfortunately, transform runtime is a very ineffective/inefficient means of polyfilling. We're in process of eliminating this transform entirely, and enabling Math would increase the global polyfills we'd need to ship by default. We'll (maybe) polyfill Math eventually, but using a custom Babel plugin, along these lines: // Incomplete
export default ({ types: t }) => {
function getName(path) {
path = path.resolve();
if (t.isMemberExpression(path)) {
return getName(path.get('object')) +'.'+ getName(path.get('property'));
}
return t.isIdentifier(path) && path.node.name;
}
return {
visitor: {
'MemberExpression|Identifier'(path) {
const name = getName(path);
const m = name.match(/^(?:(?:window|top|self)\.)*Math\.(\w+)$/);
if (!m) return;
const ident = path.scope.generateUidIdentifier(m[1]);
// todo: import helper lib
path.replaceWith(ident);
}
}
};
};Also, the reasons for adding this property were argued to be a "observable size reduction". However, this is never observed. See the diff bot shows absolutely zero difference in output with this option applied: |
This was referenced Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9511
This removes the polyfillying of the
Mathobject.This has never been polyfilled previously, nor in a stable.