docs: remove --save from npm install; avoid system-ui #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 764781e |
Timer
reviewed
Jan 24, 2020
Timer
reviewed
Jan 24, 2020
| @@ -15,7 +15,7 @@ For example, consider the following stylesheet named `styles.css`: | |||
|
|
|||
| ```css | |||
| body { | |||
| font-family: 'SF Pro Text', 'SF Pro Icons', system-ui; | |||
| font-family: sans-serif; | |||
There was a problem hiding this comment.
Hmm, this was partially intentional to show the property would get compiled.
There was a problem hiding this comment.
@Timer If we want to show that the style will change, how about monospace? That'll make the change obvious.
Or we can use the stack we use on Next.js site (which doesn't use system-ui).
chibicode
changed the title
chibicode
changed the title
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: f8391b5 |
chibicode
changed the title
Timer
approved these changes
Jan 27, 2020
Timer
changed the title
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 3f36f70 |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: c7bcf14 |
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install instructionsI think it's better to include--savetonpm install sassbecause we also do so for Next.js setup doc.npm install --save→npm install--savehas been the default fornpm installsince npm 5.system-ui
Also, I don't know where the CSS font-family stack used in the doc came from (it was added on this commit 086ce5d) but it seemed problematic.
First,
SF Pro Iconsis actually not part of a system Mac font. It seems like it's used on apple.com but is actually loaded as a webfont:https://www.apple.com/wss/fonts/SF-Pro-Icons/v1/SFProIcons_regular.woff. So if you're not on apple.com, you won't have this font.Second,
system-uishould NOT be the last font on the font stack. system-ui is not supported on Firefox (you need to use-apple-system) or Edge.Furthermore, system-ui seems to be problematic for Windows on Simplified Chinese environment. To fix this, we must put
Segoe UIbeforesystem-ui.system-uibecause of this reason and hasn't added it back.If we want to keep the stack simple and avoid adding all the system fonts, I thought we should just use
sans-serif.