Enable static 404 config to allow static 404 page when available #10290

ijjk · 2020-01-27T18:07:29Z

As discussed with @timneutkens this updates to allow using a static 404 page when there is no custom _error page and no getInitialProps in _app without having to also enable the static404 config in next.config.js

x-ref: #10113

ijjk · 2020-01-27T18:13:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	12.6s	12.5s	-77ms
nodeModulesSize	52.1 MB	52.1 MB	-2 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	13.3s	13s	-242ms
nodeModulesSize	52.1 MB	52.1 MB	-2 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_error.js gzip	46.2 kB	46.2 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.4 kB	46.4 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js gzip	69.9 kB	69.9 kB	✓
404.html gzip	N/A	1.42 kB	N/A
Overall change	305 kB	307 kB	⚠️ +1.42 kB

Commit: 2010f99

ijjk · 2020-01-27T18:14:29Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	10.9s	11s	⚠️ +68ms
nodeModulesSize	52.1 MB	52.1 MB	-2 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	11.3s	11.4s	⚠️ +158ms
nodeModulesSize	52.1 MB	52.1 MB	-2 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_error.js gzip	46.2 kB	46.2 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.4 kB	46.4 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js gzip	69.9 kB	69.9 kB	✓
404.html gzip	N/A	1.42 kB	N/A
Overall change	305 kB	307 kB	⚠️ +1.42 kB

Commit: 3298409

ijjk · 2020-01-27T19:37:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	12.6s	12.3s	-274ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +18 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	13.4s	13s	-315ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +18 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_error.js gzip	46.2 kB	46.2 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.4 kB	46.4 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js gzip	69.9 kB	69.9 kB	✓
404.html gzip	N/A	1.42 kB	N/A
Overall change	305 kB	307 kB	⚠️ +1.42 kB

Commit: 86f5859

ijjk · 2020-01-27T21:07:31Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	11.5s	11.4s	-89ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +18 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
buildDuration	11.8s	11.6s	-140ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +18 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d57b.js gzip	16.1 kB	16.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.8 kB	69.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
main-HASH.module.js gzip	4.09 kB	4.09 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15 kB	15 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.5 kB	64.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js enable/static-404	Change
_error.js gzip	46.2 kB	46.2 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.4 kB	46.4 kB	✓
link.js gzip	71.9 kB	71.9 kB	✓
routerDirect.js gzip	69.9 kB	69.9 kB	✓
withRouter.js gzip	69.9 kB	69.9 kB	✓
404.html gzip	N/A	1.42 kB	N/A
Overall change	305 kB	307 kB	⚠️ +1.42 kB

Commit: f2829b1

timneutkens · 2020-01-28T10:04:06Z

packages/next/next-server/server/next-server.ts

@@ -1084,7 +1084,7 @@ export default class Server {
    let result: null | LoadComponentsReturnType = null

    // use static 404 page if available and is 404 response
-    if (this.nextConfig.experimental.static404 && err === null) {
+    if (this.nextConfig.experimental.static404 && res.statusCode === 404) {


I think they both have to be checked:

Suggested change

if (this.nextConfig.experimental.static404 && res.statusCode === 404) {

if (this.nextConfig.experimental.static404 && (res.statusCode === 404 || err === null)) {

Rendering 404 when err is null seems to break the Production Usage › should handle failed param decoding test case

@ijjk interesting! We should probably fix that later

Enable static 404 config to allow static 404 page when available

2010f99

ijjk added this to the 9.2.2 milestone Jan 27, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners January 27, 2020 18:07

Update static 404 suite

3298409

ijjk added 2 commits January 27, 2020 13:31

Fix invalid params test case

0fe0e67

Merge remote-tracking branch 'upstream/canary' into enable/static-404

86f5859

Merge branch 'canary' into enable/static-404

f2829b1

timneutkens reviewed Jan 28, 2020

View reviewed changes

ijjk requested a review from timneutkens January 28, 2020 17:03

timneutkens approved these changes Jan 28, 2020

View reviewed changes

timneutkens merged commit f711b77 into vercel:canary Jan 28, 2020

timneutkens deleted the enable/static-404 branch January 28, 2020 21:39

This was referenced Mar 13, 2020

[Snyk] Upgrade next from 9.2.1 to 9.2.2 pixeldrew/hero-masq#10

Closed

[Snyk] Upgrade @next/mdx from 9.0.5 to 9.2.2 shahinalzahrani/docs#1

Open

This was referenced Mar 22, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.2 evantahler/next-static-hosting#3

Merged

[Snyk] Upgrade next from 9.2.1 to 9.2.2 grouparoo/next-plugins-example#3

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable static 404 config to allow static 404 page when available #10290

Enable static 404 config to allow static 404 page when available #10290

ijjk commented Jan 27, 2020

ijjk commented Jan 27, 2020

ijjk commented Jan 27, 2020

ijjk commented Jan 27, 2020

ijjk commented Jan 27, 2020

timneutkens Jan 28, 2020

ijjk Jan 28, 2020

timneutkens Jan 28, 2020

	if (this.nextConfig.experimental.static404 && res.statusCode === 404) {
	if (this.nextConfig.experimental.static404 && (res.statusCode === 404 \|\| err === null)) {

Enable static 404 config to allow static 404 page when available #10290

Enable static 404 config to allow static 404 page when available #10290

Conversation

ijjk commented Jan 27, 2020

ijjk commented Jan 27, 2020

Stats from current PR

ijjk commented Jan 27, 2020

Stats from current PR

ijjk commented Jan 27, 2020

Stats from current PR

ijjk commented Jan 27, 2020

Stats from current PR

timneutkens Jan 28, 2020

Choose a reason for hiding this comment

ijjk Jan 28, 2020

Choose a reason for hiding this comment

timneutkens Jan 28, 2020

Choose a reason for hiding this comment