With threejs example #10301
Merged
With threejs example #10301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: a181ee1 |
Should I fix the problems or still wait for the final result ? |
lfades
requested changes
Jan 28, 2020
There was a problem hiding this comment.
Can you use the public folder instead of static 🙏
You can fix the lint issues with yarn lint-fix (I can also do it for you before the merge when I test that the example works).
Sure. Both of them are done now. commit 4a0f340 Thank you |
I just pushed the changes in the same branch! is it ok or I have to create another branch? |
|
@afsanefda Don't worry about that. I'll review the example today or tomorrow 👍 |
Timer
requested changes
Feb 3, 2020
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 5d7b7ba |
|
@afsanefda Next.js supports importing CSS files now. You did not need to switch to styled-jsx! |
This is also Done . Thank you |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 0fbcc23 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 6304de0 |
Timer
approved these changes
Feb 7, 2020
|
Thanks!! |
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
Feb 11, 2020
* With threejs example * static folder replaced with public folder - linting issues resolved * CR- gitignore removed- readmea updated- css files and package removed * used plain css file insteaded of styled component * built in css added Co-authored-by: welcomebackfda <54882055+welcomebackfda@users.noreply.github.com>
This was referenced Mar 13, 2020
|
Hi @afsanefda Tried to implement Next.js with three.js... but got an compilation error, explained here: May I ask for a little help? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Next Community,
Here are two examples of using threejs in nextjs! I has some trouble using this library and I thought maybe it would be helpful to have it in canary examples.
Best Regards,
Afsane Fadaei