Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conformance checks #10314

Merged
merged 24 commits into from Mar 2, 2020

Conversation

prateekbh
Copy link
Contributor

@prateekbh prateekbh commented Jan 28, 2020

  • Adds React sync external script conformance check to next js
  • Adds Duplicate polyfill conformance check to next js(npm and polyfill.io based)

@ijjk
Copy link
Member

ijjk commented Jan 29, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 12.3s 12.6s ⚠️ +347ms
nodeModulesSize 52.1 MB 52.1 MB ⚠️ +7.32 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.1 kB 5.1 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB
commons.HASH.js gzip 4.06 kB 4.06 kB
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 69.9 kB 69.9 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 64.6 kB 64.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB
Overall change 4.76 kB 4.76 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.15 kB 1.15 kB
_error.js gzip 4.07 kB 4.07 kB
hooks.js gzip 779 B 779 B
index.js gzip 222 B 222 B
link.js gzip 2.89 kB 2.89 kB
routerDirect.js gzip 283 B 283 B
withRouter.js gzip 282 B 282 B
Overall change 9.68 kB 9.68 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 576 B 576 B
_error.module.js gzip 3.06 kB 3.06 kB
hooks.module.js gzip 371 B 371 B
index.module.js gzip 212 B 212 B
link.module.js gzip 2.46 kB 2.46 kB
routerDirect..dule.js gzip 273 B 273 B
withRouter.m..dule.js gzip 272 B 272 B
Overall change 7.22 kB 7.22 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 1.02 kB 1.02 kB
link.html gzip 1.03 kB 1.03 kB
withRouter.html gzip 1.02 kB 1.02 kB
Overall change 3.07 kB 3.07 kB

Serverless Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 12.9s 12.9s ⚠️ +24ms
nodeModulesSize 52.1 MB 52.1 MB ⚠️ +7.32 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.1 kB 5.1 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB
commons.HASH.js gzip 4.06 kB 4.06 kB
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 69.9 kB 69.9 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 64.6 kB 64.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB
Overall change 4.76 kB 4.76 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.15 kB 1.15 kB
_error.js gzip 4.07 kB 4.07 kB
hooks.js gzip 779 B 779 B
index.js gzip 222 B 222 B
link.js gzip 2.89 kB 2.89 kB
routerDirect.js gzip 283 B 283 B
withRouter.js gzip 282 B 282 B
Overall change 9.68 kB 9.68 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 576 B 576 B
_error.module.js gzip 3.06 kB 3.06 kB
hooks.module.js gzip 371 B 371 B
index.module.js gzip 212 B 212 B
link.module.js gzip 2.46 kB 2.46 kB
routerDirect..dule.js gzip 273 B 273 B
withRouter.m..dule.js gzip 272 B 272 B
Overall change 7.22 kB 7.22 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 46.6 kB 46.6 kB
404.html gzip 1.42 kB 1.42 kB
hooks.html gzip 1.05 kB 1.05 kB
index.js gzip 46.8 kB 46.8 kB
link.js gzip 72.4 kB 72.4 kB
routerDirect.js gzip 70.4 kB 70.4 kB
withRouter.js gzip 70.4 kB 70.4 kB
Overall change 309 kB 309 kB

Commit: e038dd7

@ijjk
Copy link
Member

ijjk commented Feb 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 11.8s 11.7s -172ms
nodeModulesSize 52.2 MB 52.2 MB ⚠️ +20.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.12 kB 5.12 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB
commons.HASH.js gzip 4.06 kB 4.06 kB
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 69.9 kB 69.9 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.12 kB 4.12 kB
webpack-HASH..dule.js gzip 746 B 746 B
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 64.6 kB 64.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB
Overall change 4.76 kB 4.76 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.15 kB 1.15 kB
_error.js gzip 4.07 kB 4.07 kB
hooks.js gzip 779 B 779 B
index.js gzip 222 B 222 B
link.js gzip 2.89 kB 2.89 kB
routerDirect.js gzip 283 B 283 B
withRouter.js gzip 282 B 282 B
Overall change 9.68 kB 9.68 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 576 B 576 B
_error.module.js gzip 3.06 kB 3.06 kB
hooks.module.js gzip 371 B 371 B
index.module.js gzip 212 B 212 B
link.module.js gzip 2.46 kB 2.46 kB
routerDirect..dule.js gzip 273 B 273 B
withRouter.m..dule.js gzip 272 B 272 B
Overall change 7.22 kB 7.22 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 1.02 kB 1.02 kB
link.html gzip 1.03 kB 1.03 kB
withRouter.html gzip 1.02 kB 1.02 kB
Overall change 3.07 kB 3.07 kB

Serverless Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 12.2s 11.8s -319ms
nodeModulesSize 52.2 MB 52.2 MB ⚠️ +20.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.12 kB 5.12 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB
commons.HASH.js gzip 4.06 kB 4.06 kB
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 69.9 kB 69.9 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.12 kB 4.12 kB
webpack-HASH..dule.js gzip 746 B 746 B
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 64.6 kB 64.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB
Overall change 4.76 kB 4.76 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.15 kB 1.15 kB
_error.js gzip 4.07 kB 4.07 kB
hooks.js gzip 779 B 779 B
index.js gzip 222 B 222 B
link.js gzip 2.89 kB 2.89 kB
routerDirect.js gzip 283 B 283 B
withRouter.js gzip 282 B 282 B
Overall change 9.68 kB 9.68 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 576 B 576 B
_error.module.js gzip 3.06 kB 3.06 kB
hooks.module.js gzip 371 B 371 B
index.module.js gzip 212 B 212 B
link.module.js gzip 2.46 kB 2.46 kB
routerDirect..dule.js gzip 273 B 273 B
withRouter.m..dule.js gzip 272 B 272 B
Overall change 7.22 kB 7.22 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 46.5 kB 46.5 kB
404.html gzip 1.43 kB 1.43 kB
hooks.html gzip 1.07 kB 1.07 kB
index.js gzip 46.5 kB 46.5 kB
link.js gzip 72 kB 72 kB
routerDirect.js gzip 70.3 kB 70.3 kB
withRouter.js gzip 70.1 kB 70.1 kB
Overall change 308 kB 308 kB

Commit: 5414d46

@prateekbh
Copy link
Contributor Author

prateekbh commented Feb 20, 2020

Took this for a spin on some of open codebases.
Here's what the results looks like.

Source 1:
Screen Shot 2020-02-20 at 3 01 21 PM

Source 2:
Screen Shot 2020-02-20 at 3 14 08 PM

Source 3:
Screen Shot 2020-02-20 at 3 11 25 PM

P.S.
Some of these warning are actual errors, but to start we report everything as warnings.
Also, formatting is still a WIP

@ijjk
Copy link
Member

ijjk commented Feb 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 10.6s 10.8s ⚠️ +157ms
nodeModulesSize 56.2 MB 56.3 MB ⚠️ +20.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 11.8s 11.8s -28ms
nodeModulesSize 56.2 MB 56.3 MB ⚠️ +20.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 290 kB 290 kB ⚠️ +19 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 290 kB 290 kB ⚠️ +207 B
link.js gzip 298 kB 298 kB -479 B
routerDirect.js gzip 297 kB 297 kB -183 B
withRouter.js gzip 296 kB 297 kB ⚠️ +292 B
Overall change 1.47 MB 1.47 MB -144 B

Commit: 93b8023

@ijjk
Copy link
Member

ijjk commented Feb 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 9.4s 9.2s -191ms
nodeModulesSize 56.2 MB 56.3 MB ⚠️ +21.6 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 10.2s 10.2s -24ms
nodeModulesSize 56.2 MB 56.3 MB ⚠️ +20.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 290 kB 289 kB -783 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 290 kB 289 kB -744 B
link.js gzip 297 kB 298 kB ⚠️ +63 B
routerDirect.js gzip 298 kB 297 kB -1.42 kB
withRouter.js gzip 296 kB 298 kB ⚠️ +1.24 kB
Overall change 1.47 MB 1.47 MB -1.64 kB

Commit: 2a64738

@ijjk
Copy link
Member

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 8.7s 8.8s ⚠️ +41ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 923 B 923 B
link.html gzip 932 B 932 B
withRouter.html gzip 921 B 921 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 9.4s 9.4s -11ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 292 kB 292 kB ⚠️ +233 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 292 kB 293 kB ⚠️ +161 B
link.js gzip 300 kB 299 kB -860 B
routerDirect.js gzip 298 kB 299 kB ⚠️ +1.22 kB
withRouter.js gzip 298 kB 298 kB ⚠️ +569 B
Overall change 1.48 MB 1.48 MB ⚠️ +1.32 kB

Commit: dc436d7

@ijjk
Copy link
Member

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 8.6s 8.7s ⚠️ +73ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 923 B 923 B
link.html gzip 932 B 932 B
withRouter.html gzip 921 B 921 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 9.4s 9.3s -156ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 292 kB 292 kB -351 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 292 kB 293 kB ⚠️ +452 B
link.js gzip 299 kB 300 kB ⚠️ +1.01 kB
routerDirect.js gzip 298 kB 298 kB ⚠️ +172 B
withRouter.js gzip 298 kB 298 kB -170 B
Overall change 1.48 MB 1.48 MB ⚠️ +1.11 kB

Commit: 7f57a45

@prateekbh prateekbh changed the title React external sync script check Adding conformance checks Feb 27, 2020
@ijjk
Copy link
Member

ijjk commented Mar 2, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 9.7s 10s ⚠️ +378ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.76 kB 5.76 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.3 kB 55.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.79 kB 4.79 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.3 kB 51.3 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
index.html gzip 936 B 936 B
link.html gzip 946 B 946 B
withRouter.html gzip 934 B 934 B
Overall change 2.82 kB 2.82 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
buildDuration 10.6s 10.5s -38ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +22.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.js gzip 5.76 kB 5.76 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.3 kB 55.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
main-HASH.module.js gzip 4.79 kB 4.79 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.3 kB 51.3 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary azukaru/next.js react-external-sync-script-check Change
_error.js gzip 292 kB 292 kB ⚠️ +355 B
404.html gzip 1.34 kB 1.34 kB
hooks.html gzip 975 B 975 B
index.js gzip 292 kB 292 kB ⚠️ +343 B
link.js gzip 299 kB 300 kB ⚠️ +986 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +4 B
withRouter.js gzip 298 kB 299 kB ⚠️ +1.15 kB
Overall change 1.48 MB 1.48 MB ⚠️ +2.83 kB

Commit: 1837668

@timneutkens timneutkens merged commit 16672a4 into vercel:canary Mar 2, 2020
@prateekbh prateekbh deleted the react-external-sync-script-check branch March 2, 2020 22:44
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants