Upgrade with-carbon-components to built-in SCSS #10321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 872ed20 |
Timer
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Must be a bad cache:
❯ yarn next build examples/with-carbon-components/
yarn run v1.21.1
$ node packages/next/dist/bin/next build examples/with-carbon-components/
Warning: You have enabled experimental feature(s).
Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.
Creating an optimized production build
Compiled successfully.
Automatically optimizing pages
Page Size First Load
┌ ○ / 23.4 kB 94.7 kB
└ /_app 280 B 71.3 kB
+ shared by all 71.3 kB
├ static/_buildManifest.js 61 B
├ static/pages/_app.js 280 B
├ chunks/101ffb2e.37da1e.js 64 B
├ chunks/1aaf2ccf73f5c9bd720520b374aa8fd48d0d3aff.f13d79.js 16.1 kB
├ chunks/commons.c34d60.js 8.31 kB
├ chunks/framework.3b6162.js 40.8 kB
├ runtime/main.2463fd.js 5 kB
└ runtime/webpack.91b117.js 746 B
λ (Server) server-side renders at runtime (uses getInitialProps or getServerProps)
○ (Static) automatically rendered as static HTML (uses no initial props)
● (SSG) automatically generated as static HTML + JSON (uses getStaticProps)
✨ Done in 59.40s.
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 7dbe8e1 |
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
Feb 11, 2020
Co-authored-by: Joe Haddad <timer150@gmail.com>
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example fails to compile. Having @Timer take a look.